Chaco
Level: Smitemaster
Rank Points: 3624
Registered: 10-06-2005
IP: Logged

When building a room in the room editor, if you place a potion on land and then try to build shallow water under the potion, you get the red highlight and the operation fails.

But, if you place the potion directly on shallow water, it places fine, and you can play the room fine, and the potion works normally.

So, I propose that you be allowed to build the shallow water underneath in the editor screen since there's no anomalous behavior to prevent here.

____________________________
Quick links to my stuff (in case you forgot where it was):

uncopy2002
Level: Smiter
Rank Points: 431
Registered: 07-28-2014
IP: Logged

That belongs to a much wider class of problems: for example, you can't place a keg on a broken wall directly but you can copy-paste it to make it work. Similarly, some floor tiles can't be placed on temporal tokens while you can do the opposite.

hyperme
Level: Smitemaster

Rank Points: 1062
Registered: 06-23-2006
IP: Logged

I've fixed this particular editor placement issue and pushed it to my copy of DROD on git.

However, there are more editor placement issues, and it would be nice to gather them in one place. If you think there is a placement issue, please post it here.

____________________________
[Insert witty comment here]
Qzvlkx?

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

Are there any other editor placement issues which are counter intuitive or prevent creating a valid room state?

____________________________
My website | Facebook | Twitter

navithmastero
Level: Smitemaster

Rank Points: 596
Registered: 01-03-2012
IP: Logged

Being able to place a gentryii head on top of a wall feels wrong but I guess isn't really an issue because Gentryii are invulnerable? Also being able to place a seep on top of a keg on top of a wall feels really weird, especially because, as far as I can tell, you can't create this room state in-game (i.e through pushing a keg on to a wall etc).

____________________________
Member of the Snake Appreciation Society

One of your local HAs.

My stuff:

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

Seep on T-layer on wall: It's established that you can build T-Layer things under monsters.

I do think it's an exceptional case, though, and editor should not allow such placement by default because 9999 times out of 10000 you'd rather have the monsters around the bombs, kegs and mirrors. I think we should make seep have the same placement rules as other monsters in this specific case.

Gentryii head on walls: I think this comes from the fact you place their chains on a wall. But since we don't allow any other monster to be placed on top of a wall I'd say - change this so that head has to be one the floor. This would be consistent with the fact you can't build walls under monsters at all (though you can turn into monster on a wall).


____________________________
My website | Facebook | Twitter

navithmastero
Level: Smitemaster

Rank Points: 596
Registered: 01-03-2012
IP: Logged

Agree with everything you said here. The only thing I can think is that changing that Seep placement thing would break a room in one of Disoriented's Lunch Break hold, but I don't foresee it being something which breaks (m)any other rooms.

____________________________
Member of the Snake Appreciation Society

One of your local HAs.

My stuff:

Dragon Fogel
Level: Smitemaster
Rank Points: 2434
Registered: 06-21-2014
IP: Logged

I imagine that wouldn't actually break anything, since it's not a game logic rule - it would probably even still work if you opened the hold in the editor. You just wouldn't be able to reproduce that setup without copying it or using scripting.

mauvebutterfly
Level: Smitemaster

Rank Points: 720
Registered: 05-03-2015
IP: Logged

Tar Time: Halls of Goo 1N

I'm just mentioning this as an example of a room in a published hold that makes use of the editor in a way that is no longer allowed. It contains wraithwings on top of tarstuff.

I don't actually have an issue with the editor changing and pre-existing holds being allowed to remain despite no longer conforming to editor restrictions.

Of course, with scripting, you could still make a room with wraithwings on tar, or seep on powder kegs if you wanted to, and that's fine.

____________________________
106th Skywatcher

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

Existing rooms won't be affected.

____________________________
My website | Facebook | Twitter

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

Gentryii and Seep changes done. PR

Please make a separate thread for any other editor placement you may find in the future!

____________________________
My website | Facebook | Twitter

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm the following in 5.1.1.alpha.2020-10-16:

- You can no longer place seep on top of kegs that are on walls
- You can no longer place a gentryii head on top of a wall
- You can now place shallow water directly underneath potions.