Chaco
Level: Smitemaster
Rank Points: 3684
Registered: 10-06-2005
IP: Logged

File: demo description bug hold.hold (1006 bytes)
Downloaded 43 times.
License: Public Domain

If you record a victory demo for a room that only involves monsters getting killed by briar (without the player stabbing any monsters), then the resulting victory demo will be described as "The player is just passing through", despite the fact that they cleared the room.

Compare this to the case where a monster is fried on a hot tile, where the victory demo will say "Player conquers the room after slaying just one monster", even though again the player didn't directly kill the monster.

The test hold contains two trivial rooms: The Entrance, which contains briar and a roach (and an orb to hit, which doesn't seem to affect the bug one way or another), and Once East, which contains a hot tile and a roach.

____________________________
Quick links to my stuff (in case you forgot where it was):

disoriented
Level: Smitemaster

Rank Points: 2419
Registered: 08-07-2007
IP: Logged

Also mentioned here

____________________________
34th Skywatcher

Best to PM me, since I might miss your message on CaravelNet chat.

Dragon Fogel
Level: Smitemaster
Rank Points: 2518
Registered: 06-21-2014
IP: Logged

For thoroughness, I looked at some other indirect kills. Spikes, fire traps, explosions, and Puffs all give "the player kills a handful of monsters".

On a related note, some lines in demo descriptions refer to the player as "he" - "then he leaves", "then he exits the level". Since neither the player character nor the person playing the game are necessarily male, perhaps this could be changed to "the player then leaves".

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

I've been looking into this and there are indeed some inconsistencies in kills - briar and adder eating stuff do not increase kill count but everything else indeed seems to.

I don't think it's possible to make things consistent though, it's not like you can determine whether a kill was ultimately caused by intentional player manipulation or by monsters and elements just doing their stuff.

As such, I've changed it so that both briar kills and adders eating stuff will count as monsters being killed for the purpose of generating demo descriptions (and possibly other purposes too).

PR

____________________________
My website

---

[Last edited by skell at 09-30-2020 08:03 AM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5185
Registered: 02-04-2003
IP: Logged

Dragon Fogel wrote:
some lines in demo descriptions refer to the player as "he" - "then he leaves", "then he exits the level". Since neither the player character nor the person playing the game are necessarily male, perhaps this could be changed to "the player then leaves".

Agreed. Corrected pronoun usage in this PR, which will include the updated texts packaged into the game install in the next major version (5.2).

Skell edit: the above was reported separately here

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by skell at 10-13-2020 10:55 AM]

kieranmillar
Level: Smitemaster
Rank Points: 3089
Registered: 07-11-2014
IP: Logged

Can confirm in 5.1.1.alpha.2020-10-16 that kills by briar and kills by adder both count as player kills for the purposes of demo descriptions.

Dragomir7
Level: Goblin
Rank Points: 19
Registered: 07-07-2019
IP: Logged

Dragon Fogel wrote:
For thoroughness, I looked at some other indirect kills. Spikes, fire traps, explosions, and Puffs all give "the player kills a handful of monsters".

On a related note, some lines in demo descriptions refer to the player as "he" - "then he leaves", "then he exits the level". Since neither the player character nor the person playing the game are necessarily male, perhaps this could be changed to "the player then leaves".

+1. Was playing as 84th Negotiator on her TCB level (filled with Fergundi), and all the demo descriptions look really out of place here.