Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : 5.2 Demo testing report (Rooms to check and holds to fix (volunteers needed!))
New Topic New Poll Post Reply
Poster Message
hyperme
Level: Smitemaster
Avatar
Rank Points: 1511
Registered: 06-23-2006
IP: Logged
icon 5.2 Demo testing report (+8)  
As part of the process to get 5.2 to release, several demo checks have been run to find rooms that might have been broken or affected by behavior changes. After cleaning up some regressions, there are still rooms that need checking if they can still be solved.

Rooms with invalid #1s

These are rooms that need to be replayed in 5.2.0.808, to check if that they can still be cleared. I've checked a few of them, and others have valid non-#1 demos, but I'll list all the things that cropped up. Rooms are organised by the (suspected) root cause of the demo failure.

Rooms marked with [D] have valid non-#1 demos
Rooms marked with [H] have been checked by me and found to be valid
Rooms marked with a username have had a working demo provided by that user.

Fix to horn path tie-breaking

As with other pathfinding, horns had an issue where the tie-breaking was essentially non-existent. Tie-breaking has now been added, with lower X positions preferred on North and South edges, and lower Y positions preferred on East and West edges. Edge preference is NWES overall, but a higher East edge will be picked over a lower West edge. Obviously, this only applies to squares equally close to the player when they toot a horn. Affects ten rooms:

Click here to view the secret text


Wall lights make Activate item non-blocking

Weird technical interaction with wall lights and scripts. For most objects, activating them counts as the NPC's move for the turn. Wall lights don't, but also extended that to any other object on the tile. Only affects one room:

Jmit' 2: First Level: 4 North, 3 East [H]

Brained construct

Brained constructs now path around oremites when possible. Affects one room:

Pass the Hold Around: Division of Labour: 1 North, 1 East [H]

Puffs killing seep

Puffs can now kill seep. Affects one room:

Ouroboros: Oasis: 2 South, 1 East [Dragon Fogel]

Temporal projection vulnerability change

Golem and construct temporal projections are no longer immune to being body-killed by the player. Affects seven rooms, all in The Descent of King Hesper:

Click here to view the secret text


That's all folks! Well, almost.

Holds that need fixes

Four holds require updates, all due to the same change. In 5.2, the Set player weapon command can be overridden by _MyScriptX,. This has broken rooms in four holds. The holds, and affected elements are:

Lavender Levels - Conways
Blockerture Science Laboratories - Teleport Blocks [Hold updated!]
Equine Enterprise - Horse [Hold updated!]
The Custom Element Contest Compilation - Pixie [Hold updated!]

I'll also be sending PMs to architects of affected holds.

____________________________
[Insert witty comment here]
Qzvlkx?

[Last edited by hyperme at 04-20-2025 02:35 PM]
04-05-2025 at 12:22 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Xindaris
Level: Smitemaster
Avatar
Rank Points: 1746
Registered: 06-13-2015
IP: Logged

File: XH Rank and File 1S1E Victory.demo (3.8 KB)
Downloaded 3 times.
License: Public Domain
icon Re: 5.2 Demo testing report (+2)  
Here's a demo for that room in Xindaris' First Hold.

As for the room in MaGDL Compilation, it appears that the highest-ranking demo is broken, but all of the demos ranking lower than that work.


Also, DyingFlutchman hasn't been active in quite a while, but I might be able to guess how to fix the horse to work as intended, if desired? The Unicorn also seems to use a lot of the same code as the horse, so may also be affected.

____________________________
109th Skywatcher

Here are some links to Things!
Click here to view the secret text


[Last edited by Xindaris at 04-05-2025 05:54 PM]
04-05-2025 at 05:50 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2850
Registered: 06-21-2014
IP: Logged
icon Re: 5.2 Demo testing report (+2)  
Given the change, I would guess that the issue is that the scripts use "Set Player Weapon" in the middle of a code block that makes use of _MyScriptX for other reasons.

If that's correct, this can easily be taken care of by storing the value of _MyScriptX in another variable, setting it to -9999 so it doesn't do anything, using the "Set Player Weapon" command, and then setting _MyScriptX to the stored variable afterwards.

This can be done in 5.1.1 to make the holds still playable in older versions, as all of these commands are available there.
04-05-2025 at 06:27 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Xindaris
Level: Smitemaster
Avatar
Rank Points: 1746
Registered: 06-13-2015
IP: Logged
icon Re: 5.2 Demo testing report (+1)  
That was pretty much exactly it, for my two holds on that list. The pixie didn't even need that much; the reset could just be moved to before the set player weapon command harmlessly.

The horse appears to only use "set player weapon" as a conditional when it's trying to decide whether or not it's blocked by the player's sword/staff/etc.

____________________________
109th Skywatcher

Here are some links to Things!
Click here to view the secret text

04-05-2025 at 08:00 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2850
Registered: 06-21-2014
IP: Logged

File: O Oasis 2S1E Victory.demo (31.2 KB)
Downloaded 3 times.
License: Public Domain
icon Re: 5.2 Demo testing report (+2)  
It was made in 5.1, but my demo for the Ouroboros room does not push the puff into the seep inside a wall. The seep gets pushed into the puff over water to create ice at one point, but that would kill the seep anyways as it's not in a wall, and should not be affected by the change.
04-05-2025 at 08:41 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Dischorran
Level: Smitemaster
Avatar
Rank Points: 3425
Registered: 09-10-2005
IP: Logged
icon Re: 5.2 Demo testing report (+1)  
Ugh, this seems doable since all that needs to happen seems to be to move the myscript=myx/y to be around the conway updates themselves instead of the block including temporarily removing Beethro's sword, but will be a bit of a pain. Unless I'm missing something more.

____________________________
Click here to view the secret text

04-06-2025 at 01:17 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : 5.2 Demo testing report (Rooms to check and holds to fix (volunteers needed!))
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.9
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.