Announcement: Be excellent to each other.

Caravel Forum : DROD Boards : Bugs : lingering platform-specific issues in the player validation handling code (Mac 5.1.1.624)
 New Topic New Poll Post Reply
Poster Message
disoriented
Level: Smitemaster
Avatar
Rank Points: 2482
Registered: 08-07-2007
IP: Logged
 icon lingering platform-specific issues in the player validation handling code (0)  
Issue is described in this thread:
https://forum.caravelgames.com/viewtopic.php?TopicID=46515&page=0#451854

____________________________
34th Skywatcher

Best to PM me, since I might miss your message on CaravelNet chat.
02-16-2025 at 03:45 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+2)  
Would you be OK with sending me your player saves file? I'd like to try importing it in a debug build.
02-16-2025 at 09:41 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
disoriented
Level: Smitemaster
Avatar
Rank Points: 2482
Registered: 08-07-2007
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+1)  
Sure, send me a DM

____________________________
34th Skywatcher

Best to PM me, since I might miss your message on CaravelNet chat.
02-17-2025 at 12:17 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+3)  
FWIW the crash is reproducible, the program segfaults at about 70% into the import process, because a tile of (UINT) -2 is passed into BuildUtil::BuildTilesAt, and this causes an invalid memory access at line 100:
	if (TILE_LAYER[baseTile] == LAYER_OPAQUE) {


I don't yet understand how or why this happens.
02-19-2025 at 09:38 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+3)  
I might have something:

This is the saved game that triggers the crash:
Click here to view the secret text


If there is a way to convert these opaque ids into something meaningful, I don't know it. But as I was cluelessly stumbling around in the stacktrace, I found a list of character commands that the game tried to execute while validating the save game, and some had labels that said things like "#Make everything black except for a few tiles around the player." and "#Add the torchlight.". This triggered a vague memory that I've seen a thread in this very forum about the hold Blackout:

https://forum.caravelgames.com/viewtopic.php?TopicID=46270&page=0#450127

So then I've tried to just run the game again and change location to Blackout (which I had already played), and lo and behold, it crashed in the exact same place as when I tried importing disoriented's saves.

There is an alleged Chinese saying that if you have just one problem, you might not ever be able to solve it. But if you have two problems, you may be able to play them against each other.

Next steps:
- try importing the saves, and changing location to Blackout in 5.1.0, as I strongly suspect that either or both will crash
- try to edit out the offending save games from disoriented's save file, so that he can load it
02-19-2025 at 11:29 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged

File: drod_blackout.patch (801 bytes)
Downloaded 7 times.
License: Public Domain
 icon Re: lingering platform-specific issues in the player validation handling code (+2)  
I tried changing the location to Blackout in good old 5.1.0, and it worked fine. I haven't tried importing the save file, but I expect it wouldn't have crashed (at this step - but we'll come back to that).

Currently, it is not possible to play the Blackout hold in 5.1.1, because trying to load it instantly crashes the game, and if you try to import a player file that has a saved game from a certain room (I don't know which), that also crashes the game. So instead of fixing the save file I tried to fix the code.

I think the attached patch does it, but I have zero experience with the DROD codebase, so I don't know if this breaks anything else. With the patch, I can change to Blackout, and the import process doesn't crash during the import phase.

I think the breakage was introduced in commit 9024cc990341d7c0a590d62af0f97380467a05bb.

But not all is well: the import process dies with an assertion error
drod: Assertion error in line 7297 of ../../DRODLib/CurrentGame.cpp: "this->pRoom->IsValidColRow(wX,wY)"

when at (89/338) March Madness. I think this is unrelated to the previous crash.

The part of the original report where the game suddenly decided to not allow restoring also remains unexplained. I think this is also unrelated to the import crash.
02-20-2025 at 08:05 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
hyperme
Level: Smitemaster
Avatar
Rank Points: 1360
Registered: 06-23-2006
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (0)  
The patch looks good, and shouldn't break anything. Can be PR'd into the 5.2 development branch.

____________________________
[Insert witty comment here]
Qzvlkx?
02-20-2025 at 08:19 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (0)  
Shouldn't it be backported into the 5.1.1 (master) branch as well?
02-20-2025 at 08:28 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
hyperme
Level: Smitemaster
Avatar
Rank Points: 1360
Registered: 06-23-2006
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (0)  
That can be done, but the release pipeline for Mac builds doesn't really exist, so it's questionable how useful that will be.

____________________________
[Insert witty comment here]
Qzvlkx?
02-20-2025 at 08:30 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
disoriented
Level: Smitemaster
Avatar
Rank Points: 2482
Registered: 08-07-2007
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+2)  
hyperme wrote:
That can be done, but the release pipeline for Mac builds doesn't really exist, so it's questionable how useful that will be.

If slimm tom is able to generate a new 5.1.1.x build, perhaps he can incorporate this patch as well as any other recent patches that have been merged?

____________________________
34th Skywatcher

Best to PM me, since I might miss your message on CaravelNet chat.
02-20-2025 at 10:15 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
slimm tom
Level: Smitemaster
Avatar
Rank Points: 1252
Registered: 10-14-2006
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+2)  
If the fix is ported into the 5.1.1 branch I can do that.

I can also try building 5.2 once that's fully ready, hopefully it won't cause any issues with my setup.
02-23-2025 at 09:50 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
hyperme
Level: Smitemaster
Avatar
Rank Points: 1360
Registered: 06-23-2006
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+2)  
I've picked the build crash fix back to the main 5.1.1 branch to make things easier for MacOS deployment.

5.2 is getting closer to ready but there are definitely C++11 features in there. A necessary pain point I'm afraid.

____________________________
[Insert witty comment here]
Qzvlkx?
02-24-2025 at 04:59 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
disoriented
Level: Smitemaster
Avatar
Rank Points: 2482
Registered: 08-07-2007
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+1)  
I've been playing Descent of King Hesper in the Windows version 5.1.1.624 to get around the Mac issues.
This might be the same issue again, but attempting to export either my Player or just my Player Saves causes Windows DROD to crash.

Some of the errors in drod.err seem unrelated to the crash:

Assertion error in line 2779 of BitmapManager.cpp: "this->TileImageTypes[wTileImageNo] != TIT_Unspecified"

Assertion error in line 5121 of Character.cpp: "room.pMonsterSquares[room.ARRAYINDEX(this->wX,this->wY)] == this"

Assertion error in line 7297 of CurrentGame.cpp: "this->pRoom->IsValidColRow(wX,wY)"

____________________________
34th Skywatcher

Best to PM me, since I might miss your message on CaravelNet chat.
[Last edited by disoriented at 02-25-2025 07:51 PM]
02-25-2025 at 07:50 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
NoahT
Level: Smitemaster
Avatar
Rank Points: 1209
Registered: 06-17-2003
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+1)  
disoriented wrote:
I've been playing Descent of King Hesper in the Windows version 5.1.1.624 to get around the Mac issues.
This might be the same issue again, but attempting to export either my Player or just my Player Saves causes Windows DROD to crash.
Sounds like what I experienced here.

____________________________
And in the end, the love you take is equal to the love you make.

My stuff:
Click here to view the secret text
02-25-2025 at 08:38 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+1)  
The last assertion error is likely the same as the one I've reported above.

I remember seeing the first one while playing, though I can't recall which hold triggered it.

I still have your player file, I can try debugging the player export process in the weekend if you want, though it would be tricky (I haven't even imported it yet because of the same assertion errors crashing the debug build, and I'd have to hack the source to make the original crash switchable with an environment variable or something).
02-25-2025 at 08:45 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
kikuchiyo
Level: Master Delver
Rank Points: 147
Registered: 04-01-2012
IP: Logged
 icon Re: lingering platform-specific issues in the player validation handling code (+1)  
FWIW I tried importing disoriented's player profile with the latest master branch (patch included), then exporting it with the patch commented out. No crash :shrug:
03-01-2025 at 05:19 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : lingering platform-specific issues in the player validation handling code (Mac 5.1.1.624)
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.9
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.