Doom
Level: Smitemaster

Rank Points: 3308
Registered: 07-05-2004
IP: Logged

Follow-up to this previously resolved bug.

I've discovered that the same bug still occurs under specific circumstances. My testing suggests that the Level Map item is the culprit and taking it can eventually cause previously explored rooms to vanish from the minimap after loading a save and then undoing or restarting.

Steps to reproduce:

- Create a hold with two empty, connected rooms. Add a Level Map item in the entrance room.
- Go to main menu, start a New Game and explore both rooms.
- Start a New Game again (or reload a save), so only one room is explored (the other room is visible on the map in darker color).
- Pick up the map and quicksave.
- Quickload and undo or press R to cause unexplored rooms to vanish from the minimap.

Observed in 1.2.7.330 (Steam) on Windows 10.

---

[Last edited by Doom at 06-16-2017 03:46 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5141
Registered: 02-04-2003
IP: Logged

Thanks for the report, Doom.

I believe the game load fixes I've made for 1.2.8 have resolved this issue. I am unable to reproduce it in the latest 1.2.8 dev build.

Would someone please confirm this seems fixed on your end as well?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

Doom
Level: Smitemaster

Rank Points: 3308
Registered: 07-05-2004
IP: Logged

File: Map Test.drh (718 bytes)
Downloaded 46 times.
License: Public Domain

I'm still experiencing this on 1.2.8.alpha.2020-11-10

Here's the test hold I used and the exact steps that are leading to this:

- Select New Game
- Enter 1E (doesn't matter if map is picked up, this part is just to make 1E show up on the minimap)
- Press Esc and select New Game again
- Pick up map
- Quicksave
- Quickload
- Press R

When I do this, 1E disappears from the minimap.

mrimer
Level: Legendary Smitemaster

Rank Points: 5141
Registered: 02-04-2003
IP: Logged

Thank you!

I see it now.

Fixed in this PR.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

Doom
Level: Smitemaster

Rank Points: 3308
Registered: 07-05-2004
IP: Logged

The level map item works correctly in 1.2.8.alpha.2020-11-10a, but I've found another related case where this still happens.

This can be seen in the first room of the published hold 2018 Year of the RPG Compilation, which simulates a Full-Reveal Map by running scripted reveal commands upon picking up the map.

Testing confirms that if I edit my previous test hold and replace the map item with scripted commands "Wait for player to touch me, Add room to map (1E) Full room reveal" then the same issue reappears.

---

[Last edited by Doom at 11-11-2020 08:13 AM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5141
Registered: 02-04-2003
IP: Logged

Doom wrote:
I've found another related case where this still happens.

I appreciate you helping me ferret out all of these cases.

Wow! This was a rabbit hole. I found several variants of this issue, related to room restarting, undoing moves, picking up a map in the room before that script command executes, and also with quick saves, continue saves, and other saves. I think I have these all fixed up now.

PR

PR2

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 11-11-2020 03:36 PM]

Doom
Level: Smitemaster

Rank Points: 3308
Registered: 07-05-2004
IP: Logged

Confirmed that this is working correctly on build 325.

Tried map items and reveal scripts with quicksaves and manual saves plus undo/restart, all combinations looked good.

mrimer
Level: Legendary Smitemaster

Rank Points: 5141
Registered: 02-04-2003
IP: Logged

Doom wrote:
Confirmed that this is working correctly on build 325.

Tried map items and reveal scripts with quicksaves and manual saves plus undo/restart, all combinations looked good.

Woo hoo! YAYYYYAYYYY!

So glad we were able to iron out these issues.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.