hartleyhair
Level: Smiter
Rank Points: 307
Registered: 08-05-2007
IP: Logged

File: Stalwart vs Golem.jpg (29.4 KB)
Downloaded 107 times.
License: Public Domain

In the attached screenshot, the Stalwart will not move to kill the Golem.

Is this intentional?

Note: This still happens when I remove the briar and replace it with pit.

____________________________
I'm currently working on Jerrik's Dungeon, an oldschool Hold for TCB.

Tahnan
Level: Smitemaster

Rank Points: 2460
Registered: 11-14-2005
IP: Logged

Well, of course he won't; it's a screenshoot. Things don't move in screenshots.

Er, I mean. I'm not sure I can tell what's going on there, not well enough to reproduce it. Can you attach a hold?

hartleyhair
Level: Smiter
Rank Points: 307
Registered: 08-05-2007
IP: Logged

File: Stalwart vs Golem.hold (1.2 KB)
Downloaded 51 times.
License: Public Domain

Certainly.

____________________________
I'm currently working on Jerrik's Dungeon, an oldschool Hold for TCB.

NoahT
Level: Smitemaster

Rank Points: 1197
Registered: 06-17-2003
IP: Logged

File: Stalwart Test.hold (812 bytes)
Downloaded 43 times.
License: Public Domain

Well, as you can see from this test, a stalwart in such a position will always go for the north golem (or any monster, for that matter), without regard for monster movement order. In this case, the only way to do that was by swinging, thus keeping the stalwart in danger.

-Noah

____________________________
And in the end, the love you take is equal to the love you make.

My stuff:

---

[Last edited by NoahT at 12-01-2007 08:40 PM]

schep
Level: Smitemaster

Rank Points: 865
Registered: 03-01-2005
IP: Logged

It turns out Stalwarts don't want to stab rock piles. Since there's no way the Stalwart can get to that rock golem without stabbing a rock pile (and without turning his sword, which he didn't think about), he doesn't move.

So I tried changing the Stalwart's don't-stab test from pMonster->IsFriendly() to pMonster->IsAlive() && pMonster->IsFriendly().

With that change, the Stalwart dies earlier given the solution on the scroll. The room is possible, but trickier. My demos for TCB:Frozen Depths:1N2W are unaffected, but I don't know how many other rooms in other holds might be affected. Mike, is this change worth checking in?

mrimer
Level: Legendary Smitemaster

Rank Points: 5204
Registered: 02-04-2003
IP: Logged

That seems like an appropriate fix -- stalwarts shouldn't give perceived idiosyncratic treatment to rock piles when navigating. I'm okay with you adding it. Thanks for checking that room's demos.

Hmm...we probably need a tool to check which of all published rooms would be affected by code changes (and probably a dedicated machine to run these regression tests on)...

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

coppro
Level: Smitemaster
Rank Points: 1309
Registered: 11-24-2005
IP: Logged

I can't think offhand of any room with stalwarts and rock golems, but if Stefan is listening, he would probably be very useful right now.

schep
Level: Smitemaster

Rank Points: 865
Registered: 03-01-2005
IP: Logged

Checked that change in.

mrimer wrote:
Hmm...we probably need a tool to check which of all published rooms would be affected by code changes (and probably a dedicated machine to run these regression tests on)...

This is a good idea. Obviously, it would be called the Mutant Spider.