averagemoe
Level: Smiter

Rank Points: 488
Registered: 03-22-2012
IP: Logged

My attempt to put the AE end sequence into a 5.0 cutscene ran into a snag. Apparently when a global script sets the player role to None, the player role returns to Beethro as soon as the player enters a different room, even though all the other script commands seem to work as expected.

All I want is for the player to not appear on screen throughout the majority of the cutscene, and I'd rather not have to add a set player role command to every room involved.

____________________________
There are two types of sheep in the world. Those who jump off a bridge when told to, and those who jump off a bridge when told not to. Don't be either.

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

File: Bug Report Global scripts execute too early.hold (4.5 KB)
Downloaded 38 times.
License: Public Domain

That's an interesting one. Essentially there was a bug (in my opinion) with how global scripts where processed on room entrance. They used the same code that starts a new script (which is okay), but that also meant they were preprocessed (meaning - run no-move commands) while that was happening. But they were added to the room before the room was fully initialized, and there was later code that caused Beethro's role to be reverted to not-none.

What's worse, later when all monsters were preprocessed the global scripts were preprocessed again. Meaning this script would fix your problem:

Set player role none
Wait 0
Set playyr role none

I've modified this behavior so that global scripts do not preprocess themselves when they are added during room initialization, but only later together with other monsters. I don't suppose it will break anything but we'll see - scripting bugs are the easiest to fix in published holds.

PR

Attached test hold I used to replicate the problem.

____________________________
My website | Facebook | Twitter

---

[Last edited by skell at 10-12-2020 03:06 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Yep, definitely a bug. Thank you for the fix!

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm that the attached example hold works correctly in 5.1.1.alpha.2020-10-16. The player role is correctly set to None at the start of each room.