Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : Some highscore demos downloaded from CNet cannot be re-downloaded
New Topic New Poll Post Reply
Poster Message
uncopy2002
Level: Smiter
Rank Points: 431
Registered: 07-28-2014
IP: Logged
icon Some highscore demos downloaded from CNet cannot be re-downloaded (+1)  
So I was playing The Intelligence, and it seems that disoriented and NoahT's highscore demos in all the required rooms in this hold have a problem: once they're downloaded, if you delete the demos they won't be re-enabled for you to downloaded again. I've asked in chat and it seems that Dragon Fogel had encountered this problem before as well.

This happens as soon as the first puzzle room (Briar Bushes: 1W) so it should be easy to verify.
11-29-2016 at 05:44 PM
View Profile Send Private Message to User Show all user's posts Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2430
Registered: 06-21-2014
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (0)  
Specifically, I posted this thread about it before.

Schik says it's probably a game bug and not a server bug, though.
11-29-2016 at 05:53 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2430
Registered: 06-21-2014
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (+1)  
So this post about another demo-related issue notes that demos can be marked as hidden.

My guess is that this is what's going on here - the "deleted" demos are actually just being marked as hidden, and the game is detecting those hidden demos and concluding "you already have the demo so there's no need to download it again". But you can't actually access it.
10-30-2020 at 05:26 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (0)  
Yes, that's exactly right.

Specifically, it happens for demos that indicate they complete a challenge.

Fixed in this PR

Unfortunately, this fix only corrects the issue going forward (i.e., for demos you delete using this version or later). If there are previously hidden demo records, they will remain in your data files and keep the Download button greyed out for those records.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 10-31-2020 01:23 AM]
10-31-2020 at 01:23 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2430
Registered: 06-21-2014
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (+1)  
The demos pointed to in this thread and my older one on the subject are from holds that don't have challenges.

Hopefully the fix will still affect them, but I'm just pointing this out as a heads-up in case it turns out there's a separate issue.
10-31-2020 at 01:45 AM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (0)  
Thank you. I wasn't sure on that point, and I appreciate you calling it out.

Looking at a snippet of the problematic demo in 1W (disoriented's):
<Demos SavedGameID='37479' IsHidden='0' DescriptionMessage='...' ShowSequenceNo='0' BeginTurnNo='0' EndTurnNo='112' Checksum='957350976' Flags='2748447' DemoID='22304'/>

The issue is the large Flags value. This value should never be greater than 31, as there are only 5 bitflags defined at this point (1,2,4,8,16) in DbDemos.h.

The "Challenge completed" bit is set by the large value.

This particular demo was created on 10/04/2013. Appears some bad values somehow got into that Flags data field at some point. Maybe a bad dev build. Or possibly an OS-specific issue?

A perusal of the current codebase, and nothing leaps out at me as potentially going wrong with the Flags value.

---

But to address your point, my fix should address all of these, as long as a given demo hasn't been downloaded and hidden yet.

---

Some cleanup could be done server-side (say, setting Flags to 2 if it's > 31?). That could likely be a lot of work, actually. It might not be worth the effort, given that a fix for this issue is now going out. Now the bad data values should be benign.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 10-31-2020 06:00 AM]
10-31-2020 at 05:48 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2430
Registered: 06-21-2014
IP: Logged
icon Re: Some highscore demos downloaded from CNet cannot be re-downloaded (+1)  
All right, good to know these will be covered, even if the underlying cause is a mystery for now.

The first post mentions demos by disoriented and NoahT having the issue; my older thread mentions a demo from Chaco. Off the top of my head, I know both disoriented and Chaco have mentioned using Macs, but I can't recall if that's also the case with NoahT.

So I'm not going to state anything conclusively but that does seem like a possible common factor.
10-31-2020 at 06:34 AM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : Some highscore demos downloaded from CNet cannot be re-downloaded
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.