Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : Build markers for cracked and damaged orbs invalid
New Topic New Poll Post Reply
Poster Message
kieranmillar
Level: Smitemaster
Rank Points: 3145
Registered: 07-11-2014
IP: Logged
icon Build markers for cracked and damaged orbs invalid (0)  
Trying to place a build marker for cracked and damaged orbs instead places a build marker for something that appears to be the corner of a black door? When an engineer tries to build it nothing is actually built. Trying to place a large number of the markers also causes huge performance issues, presumably as they struggle to figure out what to do with them.

On a slightly related note, regular orbs can be built fine, but have no build marker image.

Using version 5.1.0.6345

[Last edited by kieranmillar at 01-15-2016 08:17 PM]
01-15-2016 at 08:14 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 3145
Registered: 07-11-2014
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (0)  
So it turns out that this has been spamming my drod.err file but not making any beep sounds like it normally does, so I didn't realise.

My drod.err now contains about 10,000 lines of this:

*** FIRST LOG IN SESSION 1/16/16 11:33PM ***
Assertion error in line 75 of .\Building.cpp: "wTile < 255"
Assertion error in line 2254 of .\TileImageCalcs.cpp: "IsValidTileNo(wTileNo)"
Assertion error in line 2254 of .\TileImageCalcs.cpp: "IsValidTileNo(wTileNo)"
Assertion error in line 2254 of .\TileImageCalcs.cpp: "IsValidTileNo(wTileNo)"
Assertion error in line 2254 of .\TileImageCalcs.cpp: "IsValidTileNo(wTileNo)"

with that TileImageCals line repeated thousands of times.
01-16-2016 at 11:36 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3776
Registered: 12-28-2004
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (0)  
Alright, so generally this is not as easy as it seems to be, as I want to clean some things up.

Generally, in my opinion, the Build Marker and Build command have a couple of small inconsistencies which I think should be squashed:
- You can't place Build Marker of mirror on tarstuff, the build marker will not be placed. But you can place it next to tarstuff which then can grow onto the markers and the citizen can build the mirrors (destroying tar in process). Why not just allow placing these markers on top of tar in the first place?
- The same goes for other T layer elements.
- You can even use this to build a mirror or a bomb under an enemy or the player.
- At the same time you can't use Build command to build those mirrors on tarstuff.

My proposal is as follows:
- Allow placing build marker of any kind on anything.
- If you try to place a build marker of the thing that already exists there it will of course not work.
- We will also disallow placing build markers on master walls and hold completion walls.
- Everything else is fair game.
- The same for the regular build command - you can place anything on anything. If that layer on that tile is already occupied, the item will be simply replaced.

The reason I want to streamline is twofold - simplicity of the rules and making it possible to refactor the two places the whole build code is stored into a single function.

____________________________
My website
01-17-2016 at 10:41 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5199
Registered: 02-04-2003
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (0)  
I'm okay with this.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
01-17-2016 at 03:19 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3776
Registered: 12-28-2004
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (+2)  
This has been fixed in a big refactor along with these two:
- http://forum.caravelgames.com/viewtopic.php?TopicID=39870
- http://forum.caravelgames.com/viewtopic.php?TopicID=40372

Build markers for all elements that are allowed to be built should now work correctly.


____________________________
My website
01-24-2016 at 07:56 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2584
Registered: 06-21-2014
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (0)  
Confirmed while testing other things, build markers for cracked and broken orbs are working correctly.
02-17-2016 at 11:29 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2584
Registered: 06-21-2014
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (0)  
Update to the above.

Right-clicking a build marker for a broken orb shows "Build Marker: &Return"
Right-clicking a build marker for a cracked orb shows "Build Marker:" with nothing after it.
02-17-2016 at 11:43 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3776
Registered: 12-28-2004
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (+1)  
Things fixed for the release candidate after 5.1.0.6462:
- Proper labels are displayed when right-clicking all orb markers

____________________________
My website
02-18-2016 at 04:39 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
Dragon Fogel
Level: Smitemaster
Rank Points: 2584
Registered: 06-21-2014
IP: Logged
icon Re: Build markers for cracked and damaged orbs invalid (+1)  
Confirmed in 5.1.0.6478, build markers for cracked and broken orbs are functional and correctly labeled.
02-26-2016 at 06:54 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : Build markers for cracked and damaged orbs invalid
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.9
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.