I'm noticing plenty of that bug where the "Best Demos on CaravelNet" widget in the Select Demo Screen seems to be results for a different room than what I selected.

schep wrote:
Well, here's the problem. It turns out I explored and conquered all those rooms before I ever imported the hold. That is, a backup version of my 3.0.0 player.dat already has the room IDs in question in my ST_PlayerTotal stats, even though rooms with those IDs don't exist in that DB. So when another hold is added, it generates new room IDs that happen to be premarked as conquered in my player. Looks like I have a few thousand more rooms preconquered, too.

rm ~/.caravel/drod-3_0-custom/*.dat
cp player.dat.backup ~/.caravel/drod-3_0-custom/player.dat
drod-tcb-debug

  const UINT totalGameID =
    thedb.SavedGames.FindByType(ST_PlayerTotal, 10001, false);
  CDbSavedGame *totalGame = thedb.SavedGames.GetByID(totalGameID);
  const CIDSet& explored = totalGame->ExploredRooms;
  for (CIDSet::const_iterator iter = explored.begin();
       iter != explored.end(); ++iter) {
    std::cout << " " << *iter;
    if (!thedb.Rooms.Exists(*iter))
      std::cout << "*";
  }
  std::cout << std::endl;

schep wrote:
I still don't have any idea how RoomIDs past the end of my Rooms database view got into the PlayerTotals save. But since other DRODers have been noticing auto-conquered rooms without viewing demos, I'm guessing whatever it is happened to a number of 3.0.0 users.

I've checked in some changes that might help with this issue a bit, and in any case shouldn't harm anybody else. There's a new method DbSavedGames::CleanupPlayerTallies() to remove all invalid Room IDs from all ST_PlayerTotals saves.

schep wrote:
None of these changes do anything about the damage already done when holds were imported. I'm still thinking of figuring out a way to do something about that, but it can't really be done automatically....

schep wrote:
In both 3.0 and some builds of 3.1 (I think), viewing another player's demo can incorrectly add to your conquered counts. Did you ever fetch a demo and transfer it back to the PC?

schep wrote:
If not, did you play some in 3.0.0 and then upgrade to 3.1? We still don't know whether this other mysterious bug survived to 3.1.

Tahnan wrote: ...

Rabscuttle wrote:
2: They could both be true - you could have found the secret room but not conquered it. (Although that's obviously not the case here)

Tahnan wrote:
(Is this an import-the-demo thing? I thought that gave you credit for conquering secret rooms you hadn't conquered, not for exploring secret rooms you hadn't explored.)