Timo006
Level: Smitemaster

Rank Points: 518
Registered: 07-19-2006
IP: Logged

Again a few minutes ago, I was changing one of my own holds and I was placing master walls. I saw that, if you have a piece of tar and underneath it a wall, that if you place a master wall under it, the normal walls will be replaced, without having to delete the normal wall.. While walls that weren't covered by tar, didn't had this effect. So I think this is a bug.

____________________________
Drod Number: 3034; 8th person to see the Second Sky

tokyokid
Level: Smiter

Rank Points: 453
Registered: 05-06-2006
IP: Logged

Yeah... that happens to me too. I don't believe it's a bug, but just a convenience of the Editor.

NiroZ
Level: Smitemaster
Rank Points: 1302
Registered: 02-12-2006
IP: Logged

tokyokid wrote:
Yeah... that happens to me too. I don't believe it's a bug, but just a convenience of the Editor.

In that case it would happen with out the tar.

tokyokid
Level: Smiter

Rank Points: 453
Registered: 05-06-2006
IP: Logged

No, it only happens when there is tar or mud over the wall.

Kevin_P86
Level: Smitemaster

Rank Points: 535
Registered: 06-28-2005
IP: Logged

Exactly. So it is inconsistent, which is what raises the suspicion that it is a bug. This is exactly the point of the report: it is inconsistent, so it is at least possibly a bug.

____________________________
+++++[>+++++<-]>[>+++>++++>+++++<<<-]>.>+.>-------.<++++.+++++.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Kevin_P86 wrote:
Exactly. So it is inconsistent, which is what raises the suspicion that it is a bug. This is exactly the point of the report: it is inconsistent, so it is at least possibly a bug.

Yeah, this sounds like an oversight. I'll look into fixing it soon.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

While we're at it, you should not be able to place Beethro on master walls only if you've mastered the hold you're editing. (No, seriously. You can, but you can't place master walls under Beethro in any circumstances).

Actually, this should work with any wall. Here's why:

Within CEditRoomWidget::IsSafePlacement, there are multiple fallthroughs. (this is bad and has some other undesirable effects, like the ability to put an open yellow door under a seep). However, what stands out is that the very last thing checked is whether the square is empty. As such, what happens is that it says "Is there tar here?" and if it says yes, immediately returns true. IMHO, that entire function could make do with a rewrite.

Maybe a new function is in order, IsSafeRemoval. I don't think that you should be able to remove the walls out from under seeps, for example.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

coppro wrote:
Within CEditRoomWidget::IsSafePlacement, there are multiple fallthroughs. (this is bad and has some other undesirable effects, like the ability to put an open yellow door under a seep). However, what stands out is that the very last thing checked is whether the square is empty. As such, what happens is that it says "Is there tar here?" and if it says yes, immediately returns true. IMHO, that entire function could make do with a rewrite.

I agree.

Maybe a new function is in order, IsSafeRemoval. I don't think that you should be able to remove the walls out from under seeps, for example.

I see that does have some benefits, but it would also restrict the order that architects are able to place stacked items. Where possible, I'd rather not force removing items in order like this.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

Banjooie
Level: Smitemaster

Rank Points: 1645
Registered: 12-12-2004
IP: Logged

I like having seeps that aren't on walls, you can make neat effects with their delicious green dying bits.

Tahnan
Level: Smitemaster

Rank Points: 2459
Registered: 11-14-2005
IP: Logged

Yeah, why exactly is it that seeps die green?

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

Because they are made of gas.

Briareos
Level: Smitemaster

Rank Points: 3516
Registered: 08-07-2005
IP: Logged

coppro wrote:
Because they are made of gas.

What was that down-mod for?

Why couldn't seeps be moving bags of noxious green gas? That at least would explain how they kill Beethro...

np: 'Weird Al' Yankovic - Close But No Cigar (Straight Outta Lynwood)

____________________________
"I'm not anti-anything, I'm anti-everything, it fits better." - Sole
R.I.P. Robert Feldhoff (1962-2009)

---

[Last edited by Briareos at 10-21-2006 10:03 AM]

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

There is a level entrance text in JtRH that specifically says that seep are "...an amassage of plendorous vapors...".

Jatopian
Level: Smitemaster
Rank Points: 1842
Registered: 07-31-2005
IP: Logged

coppro wrote:
There is a level entrance text in JtRH that specifically says that seep are "...an amassage of plendorous vapors...".

According to dictionary.com, "plendorous" is not a real word. What's it supposed to mean?

____________________________
DROD has some really great music.
Make your pressure plates 3.0 style!
DROD architecture idea generator

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

I honestly don't know. Anyone care to comment (Erik)?

---

[Last edited by coppro at 10-22-2006 01:49 AM]

Schik
Level: Legendary Smitemaster

Rank Points: 5381
Registered: 02-04-2003
IP: Logged

Perhaps it's supposed to be splendorous.

____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi

Tahnan
Level: Smitemaster

Rank Points: 2459
Registered: 11-14-2005
IP: Logged

The word seems cromulent to me, at any rate.

Banjooie
Level: Smitemaster

Rank Points: 1645
Registered: 12-12-2004
IP: Logged

Every syllable is intended to be the one I heard?

Briareos
Level: Smitemaster

Rank Points: 3516
Registered: 08-07-2005
IP: Logged

Jatopian wrote:
"plendorous" is not a real word. What's it supposed to mean?

Mothing, really...

np: Rhythm & Sound ft. Freddy Mellow - Truly (Vladislav Delay Remix) (See Mi Yah Remixes)

____________________________
"I'm not anti-anything, I'm anti-everything, it fits better." - Sole
R.I.P. Robert Feldhoff (1962-2009)

Jatopian
Level: Smitemaster
Rank Points: 1842
Registered: 07-31-2005
IP: Logged

Tahnan wrote:
The word seems cromulent to me, at any rate.

There's another one. Are you lot trying to mess with my mind?

____________________________
DROD has some really great music.
Make your pressure plates 3.0 style!
DROD architecture idea generator

Niccus
Level: Smiter
Rank Points: 308
Registered: 07-02-2006
IP: Logged

Jatopian wrote:

Tahnan wrote:
The word seems cromulent to me, at any rate.

There's another one. Are you lot trying to mess with my mind?

Unpossible.

Jatopian
Level: Smitemaster
Rank Points: 1842
Registered: 07-31-2005
IP: Logged

...ah. Next time I'll check other places than dictionary.com.
But I still don't know what "plendorous" is. Google can't even find it anywhere on the internet, save as a proper name on some non-English sites. (Wait, shouldn't it have found this thread?)

____________________________
DROD has some really great music.
Make your pressure plates 3.0 style!
DROD architecture idea generator

eytanz
Level: Smitemaster

Rank Points: 2708
Registered: 02-05-2003
IP: Logged

It's a made-up word Erik invented. It has no meaning in this world, but clearly refers to some sort of property gasses may have in the Eighth.

____________________________
I got my avatar back! Yay!

schep
Level: Smitemaster

Rank Points: 865
Registered: 03-01-2005
IP: Logged

To get back to a previous point, here's another reason it's good to allow removing walls from under seeps. I was recently editing something where I wanted to first design placement of walls and seeps, then change some of the walls to closed yellow doors. It would have been annoying to need to replace the seeps, or worse, to remove them, change the tile type, then put them back.