kieranmillar
Level: Smitemaster
Rank Points: 3126
Registered: 07-11-2014
IP: Logged

If you cut alive tarstuff connected to a mother, briar does not expand. But fighting the mother directly in the eye does expand briar.

This feels inconsistent, you fight the mother when cutting tarstuff, it should count as a fight.

kieranmillar
Level: Smitemaster
Rank Points: 3126
Registered: 07-11-2014
IP: Logged

CCurrentGame::AdvanceCombat seems to specifically separate out cutting tarstuff vs a normal monster and doesn't run ProcessMonsterDefeat.

https://github.com/CaravelGames/drod/blob/9ce8dba1b3dbf834f6fe14a994113d36be0ff9e0/drodrpg/DRODLib/CurrentGame.cpp#L3169

Not sure why.

Dragon Fogel
Level: Smitemaster
Rank Points: 2539
Registered: 06-21-2014
IP: Logged

I would guess that code is intended for regular tarstuff cutting, and nobody thought to make it work with mothers.

Doom
Level: Smitemaster

Rank Points: 3332
Registered: 07-05-2004
IP: Logged

Element          Grows Eggs    Grows Briar
-----------------------------------------
Snake tails      X             X
Roach eggs       -             X
Mother-tar       X             -
Everything else  X             X

It is a bit surprising. Eggs not spawning more eggs is a sensible exception, but you'd expect eggs and briar to have the same conditions for everything else.

kieranmillar
Level: Smitemaster
Rank Points: 3126
Registered: 07-11-2014
IP: Logged

It turns out we don't run ProcessMonsterDefeat because we don't actually want mothers to be killed immediately because we might not be fighting an eye directly.

After trying a number of things, the simplest fix is to just process briar growth during this special case carve-out for mothers.

PR