Dragon Fogel
Level: Smitemaster
Rank Points: 2467
Registered: 06-21-2014
IP: Logged

I happened to glance at this old thread and while the main request was addressed, kieran mentioned something towards the end of the original post:

Alternatively, might simplify things if Custom Shields and Custom Accessories also worked with the Each Attack command, but this by itself is not enough because sometimes you will want this scripting to work without being tied to a particular piece of equipment.

Of course I have no idea how the code works so I don't know what the best solution would be. Maybe because in RPG using the command key works as a hidden piece of equipment it too could have Each attack and Each Defend work with it? I dunno!

I don't know much about RPG scripting, but this sounds like a good idea, so here's a thread requesting it.

mrimer
Level: Legendary Smitemaster

Rank Points: 5153
Registered: 02-04-2003
IP: Logged

PR (thanks, hyperme!)

Kieran, hyperme:
I'm merging this change for 1.3, but I'm guessing this change might modify/break some preexisting custom equipment scripted usage. Do we have a sense for what the potential scope of impact would be?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2868
Registered: 07-11-2014
IP: Logged

I think it is highly likely the impact on existing published holds is zero.

I am only aware of a single hold that uses Each Attack, and that's the mimic sword in Washed Ashore. However it's a weapon that uses Each Attack because Each Victory didn't exist back then. And this change won't affect that.

I'm very confident Each Attack wasn't used on a custom shield or accessory and similar for Each Defend, because it didn't work, so nobody would have done it.

mrimer
Level: Legendary Smitemaster

Rank Points: 5153
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
I think it is highly likely the impact on existing published holds is zero.

I am only aware of a single hold that uses Each Attack, and that's the mimic sword in Washed Ashore. However it's a weapon that uses Each Attack because Each Victory didn't exist back then. And this change won't affect that.

I'm very confident Each Attack wasn't used on a custom shield or accessory and similar for Each Defend, because it didn't work, so nobody would have done it.

Thank you for confirming! Glad to hear we expect this to be a non-impactful expansion in functionality.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.