skell
Level: Legendary Smitemaster

Rank Points: 3875
Registered: 12-28-2004
IP: Logged

File: BUG REPORT Wall Light vs Activate Item At.hold (1.3 KB)
Downloaded 45 times.
License: Public Domain

Script command "Activate Item At" is:

- Blocking when targeting a tile with an orb
- Non-blocking when targeting a tile with wall-light
- Non-blocking when targeting a tile with both an orb and a wall-light

Blocking / non-blocking refers to the command stopping the execution of the script for the turn. Like Wait 0 is blocking but "Set var" is non-blocking.

I kind of get why activating wall-light is non-blocking, but in my opinion a light on top of a normally-activable item should not make the operation non-blocking, because Wall Light are purely for decoration, and you risk accidentally breaking a script by changing visuals. Like I did today, apparently.

Attached example hold.

____________________________
My website

averagemoe
Level: Smitemaster

Rank Points: 556
Registered: 03-22-2012
IP: Logged

Now this begs the question, what will this mean for the scripting that turns off the lights in the 5.0 version of JTRH, Sixth Level: 1S1W?

____________________________
The internet is no place to act like a wild animal.

skell
Level: Legendary Smitemaster

Rank Points: 3875
Registered: 12-28-2004
IP: Logged

Proposed solution: Add a flag to the command that overrides any inherent "waintingness" of whatever is on the target tile.

Deferred for 5.2

____________________________
My website

mrimer
Level: Legendary Smitemaster

Rank Points: 5437
Registered: 02-04-2003
IP: Logged

Additional PR (thanks, hyperme!)