Kwakstur
Level: Smiter

Rank Points: 385
Registered: 05-05-2006
IP: Logged

I think this sword is working nice, so I go to test it out in a place larger than 1 room. The moment I reach the screen edge, though, I get an endless stream of beeps. It took me forever to Alt-tab out and get up the Task Manager to end the process! drodrpg.err grew by 220 kB! It has thousands of this line:

Assertion error in line 4918 of .\DbRooms.cpp: "wX < this->wRoomCols"

I'm pretty sure what caused the error. This sword turns all water under it to bridges. When I reach the edge, if I face West, the sword ends up off the screen, so the game is instructed to check an area off screen boundaries.

It's perfectly reasonable that the game produces an error for this, as it tells the architect he should fix his code. But I wish the game would do what it normally does in an infinite loop and end the NPC. This way, the architect doesn't feel the need to reset his computer before he can fix it.

I would prefer that the public don't download the hold. I do plan to release this sword to the public, but not in this unfinished state. So delete the attatchment once you have it, mods.

[removed attachment -- mrimer]

____________________________
Also known as ExpHP everywhere else.

---

[Last edited by mrimer at 01-14-2016 05:05 AM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

If this is still an issue I'm going to fix it.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

Confirmed the IsTileAt script command isn't applying the same limits and guards that DROD 3 and higher applies.

I've added the following checks, similar to what is used in the IsTileAt script command in regular DROD:

* The region being considered is cropped to a valid room region.

Fixed in rev 105.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 01-14-2016 05:26 AM]

kieranmillar
Level: Smitemaster
Rank Points: 2806
Registered: 07-11-2014
IP: Logged

Checking for an item out of bounds, and trying to build something out of bounds by using MyScript variables did not cause the game to throw an error 1.2.3.116.