skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

File: SweetDreamsImageOverlay.png (33.8 KB)
Downloaded 155 times.
License: Public Domain

This is a screenshot of exactly the same hold from two different versions of DROD, 5.1 being the Steam version and 5.1.1 the latest alpha (And, coincidentally, I have the same result when building the project on my own).

My guess is that either the update of SDL from 2.0.5 to 2.0.12 broke it or something changed in the PNG library or, I dunno, somehow transparency is just not loaded.

____________________________
My website

---

[Last edited by skell at 09-26-2020 10:06 PM]

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

File: test.hold (1.4 KB)
Downloaded 48 times.
License: Public Domain

Attaching the test hold

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

It seems like there was an issue relating to transparency in PNGs introduced in SDL 2.0.10 and it was fixed in 2.0.12, perhaps it's related: https://discourse.libsdl.org/t/will-be-solved-in-2-0-11-png-w-transparency-breaks-in-sdl-2-0-10-but-works-in-sdl-2-0-9/26501/9

I'll make some tests with different PNGs to see how that affects things.

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

I can confirm 32-bit PNGs with alpha channel (at least the few I checked) DO NOT have this problem. It only has an issue with ones that use a palette with transparent color. I'll see about fixing this issue.

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

Here's a PR fixing the problem - https://github.com/CaravelGames/drod/pull/58

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3771
Registered: 12-28-2004
IP: Logged

There were a few more problems I've discovered with palette-based PNGs:

1. Having an image overlay during the death fade out animation would crash the game (happened in 5.1 and 5.1.1 before my fix)
2. Changing opacity of the image overlay would make it behave erratically (happened in 5.1.1 before my fix)

I feel like the original handling might've been implemented as a workaround for some bug or for making it faster to import the palette-based images.

Note for testers: when new alpha build is made please make sure to check holds which use image overlays. Notable ones I can think of are:



Also if there are holds which use custom characters and portraits a lot (TSS again will be a candidate) it'd be a good idea to check them too.

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 2929
Registered: 07-11-2014
IP: Logged

In 5.1.1.alpha.2020-10-16 I had a play around with TSS and DROD Touch, and image overlays and character portraits seemed fine as far as I can tell.

---

[Last edited by kieranmillar at 10-17-2020 02:15 PM]