Kaelyn
Level: Delver
Rank Points: 76
Registered: 01-21-2019
IP: Logged

You can set a character's processing sequence to 10,000,000 or bigger, but if you try to open the screen again, the game will lag for a few seconds, then crash to desktop.

If you reopen the game and press the Options button again, the game will crash again. The only way to keep the game from crashing is to either never touch the Options button or to delete the character entirely.

I can't find anything in the error logs. I'm on build 6505.

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

That was a buffer overflow. PR: https://github.com/CaravelGames/drod/pull/63

When testing make sure to test both character options dialogs - the one on the "edit specific character" window and the one when editing custom character.

____________________________
My website | Facebook | Twitter

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm in 5.1.1.alpha.2020-10-16 that putting a really big number into the processing sequence no longer crashes the game upon reopening the options dialog.

Tried both places, no crashing happened.