Insoluble
Level: Smitemaster

Rank Points: 1639
Registered: 09-04-2014
IP: Logged

File: Tar gate transformation.hold (933 bytes)
Downloaded 49 times.
License: Public Domain

This is pretty minor and probably has to do with when tarstuff gates are toggled within turn processing. It is possible to have a room with no tar in it and a closed targate that changes into a room with no tarstuff in it and an open targate. In the attached hold, the tarmother eye is not on tar. On the same turn that it grows, a powder keg goes off due to floorspikes and destroys the tar that grew under it. The tarstuff gates toggle.

____________________________
Links to neat forum tools that I always have trouble finding:

mrimer
Level: Legendary Smitemaster

Rank Points: 5134
Registered: 02-04-2003
IP: Logged

Thanks for posting this.

If I understand correctly, you're saying that the correct behavior should be that the targate does not toggle on this turn in this scenario?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

Dragon Fogel
Level: Smitemaster
Rank Points: 2467
Registered: 06-21-2014
IP: Logged

I tested a similar scenario with a keg on a fire trap, and activating the fire trap on turn 30 left the doors in the same position as when the turn started. I don't know if that's happening due to no toggling or due to the doors toggling twice, but presumably what happens in that situation should also happen in this one.

Insoluble
Level: Smitemaster

Rank Points: 1639
Registered: 09-04-2014
IP: Logged

Yeah, I guess the expected behavior would be for the doors to toggle twice, though I cringe at the thought of the room that requires that bit of technical arcana. I think it makes sense as long as the doors remain in the same state though (since there is no tarstuff in the room either before or after).

What's probably happening with the spike trap vs fire trap is that the spike traps get processed earlier in the turn than the fire traps. Oddly enough, spike traps are supposed to process before tar gates toggle while fire traps are supposed to process after. This is according to skell's super cool master list of turn order processing:

https://docs.google.com/document/d/1QS9Vk3xsd4jlGF23J8p7c2IM5cmhwmoe6eCEaaAn8jY/edit#heading=h.ocovx14zokm4

The order is supposed to be
1) Tar grows
2) Spikes process
3) tar gates toggel
4) fire traps process

So I would have thought fire traps would have been the problematic element since they happen after gates toggle. Not sure what's going on.

____________________________
Links to neat forum tools that I always have trouble finding:

mauvebutterfly
Level: Smitemaster

Rank Points: 771
Registered: 05-03-2015
IP: Logged

An easy check for whether the door closes zero or two times would be to have a closed door with a fuse on it.

I agree that going from no tarstuff to no tarstuff should leave the doors in the same state, although depending on turn sequencing of events there could possibly be a single turn with the door toggled from its initial state.

____________________________
106th Skywatcher

skell
Level: Legendary Smitemaster

Rank Points: 3764
Registered: 12-28-2004
IP: Logged

I just reproduced this issue with debugger attached and the explanation is fun - the tar gates are NOT re-closed immediately when the tar grows, but the tar counter grows. Before the toggling happens, though, spikes hit keg which explodes the newly created tar which reduces the tar count to 0 which means tar gates have to toggle. So now there is 0 tar and the gates are the opposite way. When the time comes to toggle the tar gates from tar growth there is no tar left so the game thinks "okay, nothing to do here, I'll leave things as they are kthxbai".

I'll write a few test cases and fix it - because the current untoggle happens at the wrong time, I'll fix it by this situation causing no toggle to happen at all.

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3764
Registered: 12-28-2004
IP: Logged

PR: https://github.com/CaravelGames/drod/pull/69

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 2842
Registered: 07-11-2014
IP: Logged

I checked the example hold, modifying it to put fuses on the doors. In 5.1.1.alpha.2020-10-16, on turn 30, no toggling occurs, in line with what skell said he would make happen when this situation occurs, the fuses remained in tact.

---

[Last edited by kieranmillar at 10-17-2020 02:36 PM]