skell
Level: Legendary Smitemaster

Rank Points: 3768
Registered: 12-28-2004
IP: Logged

(adding missing threads for features implemented in 5.0.2)

Pressing enter in the command selection window should add the command.

Implemented in 5.0.2

____________________________
My website

Insoluble
Level: Smitemaster

Rank Points: 1639
Registered: 09-04-2014
IP: Logged

I tested for every command in 5.0.2.1004 and it works fine save for two commands.

1) If you try to press the enter key with the Set Var command selected it does not work. It either does nothing if you have filled out the required values for a variable, or an error message pops up that says "You must supply a name to add a new variable" (though when you do try to type in a new variable, it will still not work.) Clicking on the okay button will still behave normally.

2) If you try to press enter in the Wait until var command selected it does absolutely nothing in all cases as far as I can tell.

The "You must supply a name to add a new variable" error message is particularly interesting because other commands that require an input will just fail and bring you back to the "custom character" screen if you don't supply the necessary input. For example, Answer Option will return you to "custom character" (after pushing enter or clicking okay) if you haven't entered any dialog text, and Go to, and Go sub will do so (agian for both enter and clicking okay) if there are no labels to select from. It might be nice to have a similar error message for these cases, just for consistency.

____________________________
Links to neat forum tools that I always have trouble finding:

skell
Level: Legendary Smitemaster

Rank Points: 3768
Registered: 12-28-2004
IP: Logged

Insoluble wrote:
It either does nothing if you have filled out the required values for a variable, or an error message pops up that says "You must supply a name to add a new variable" (though when you do try to type in a new variable, it will still not work.) Clicking on the okay button will still behave normally.

I am fairly sure this error message should only appear if you have focus on the "variable name" field. Otherwise it should work fine, so I guess we're back to square one .

I am speaking from memory since I don't have access to the code right now!

____________________________
My website

Insoluble
Level: Smitemaster

Rank Points: 1639
Registered: 09-04-2014
IP: Logged

skell wrote:
I am fairly sure this error message should only appear if you have focus on the "variable name" field. Otherwise it should work fine, so I guess we're back to square one .

I am speaking from memory since I don't have access to the code right now!

Ahh, I was not aware of that term thank you! So to be more concise, this appears to work correctly if the focus is on the variable name and nothing has been typed in. It does not work correctly otherwise (i.e. pressing enter does absolutely nothing if the focus is elsewhere.)

____________________________
Links to neat forum tools that I always have trouble finding:

skell
Level: Legendary Smitemaster

Rank Points: 3768
Registered: 12-28-2004
IP: Logged

Alright, what happens when you hit enter depending on currently focused element should now work correctly in 5.1

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 2868
Registered: 07-11-2014
IP: Logged

Building off of the testing previously done by Insoluble (I have not meticulously checked every command):

Insoluble wrote:
I tested for every command in 5.0.2.1004 and it works fine save for two commands.

1) If you try to press the enter key with the Set Var command selected it does not work. It either does nothing if you have filled out the required values for a variable, or an error message pops up that says "You must supply a name to add a new variable" (though when you do try to type in a new variable, it will still not work.) Clicking on the okay button will still behave normally.

This now works correctly in Build 5.1.0.1006

Insoluble wrote: 2) If you try to press enter in the Wait until var command selected it does absolutely nothing in all cases as far as I can tell.

This now works correctly too