Kwakstur
Level: Smiter

Rank Points: 385
Registered: 05-05-2006
IP: Logged

File: Bug Question.drh (1.1 KB)
Downloaded 56 times.
License: Public Domain

(ahem)
I accidentally first posted this to DROD Bugs. Here's the board it should be on.

I want to put a question as an If... Condition (so that it executes in the same turn) in an Each Use label for a weapon, but when I do so, it always results to true!

Hold attatched.

____________________________
Also known as ExpHP everywhere else.

TFMurphy
Level: Smitemaster
Rank Points: 3118
Registered: 06-11-2007
IP: Logged

Since this bug's still to be fixed, I thought I'd post a related one here based around Fang's problems with his recent script.

A Answer-based Question asked in a Cmd script fired via Each Use does *not* pause its execution when the Question is asked. As a result, whatever is immediately after the question is run first, no matter what the result of the Question is. Only on the turn after the Question does the correct result occur. [Fixed in rev 282 -- mrimer]

EDIT: Tahnan's also found that it's impossible to undo past a Yes/No Question, so I'm adding that to the list of Question bugs in this thread.

---

[Last edited by mrimer at 03-19-2016 10:28 PM]

kieranmillar
Level: Smitemaster
Rank Points: 3585
Registered: 07-11-2014
IP: Logged

Going to selfishly bump this because it turns out it's a bit of an issue in something I just tried to implement. Would be great to help add more flexibility to what you want pressing the command button to do.

Dragon Fogel
Level: Smitemaster
Rank Points: 2764
Registered: 06-21-2014
IP: Logged

TFMurphy wrote:
EDIT: Tahnan's also found that it's impossible to undo past a Yes/No Question, so I'm adding that to the list of Question bugs in this thread.

Seeing this reminds me that this is happening in regular DROD, too. I'll go make a bug report over there.

mrimer
Level: Legendary Smitemaster

Rank Points: 5415
Registered: 02-04-2003
IP: Logged

Kwakstur wrote:
(ahem)
I accidentally first posted this to DROD Bugs. Here's the board it should be on.

I want to put a question as an If... Condition (so that it executes in the same turn) in an Each Use label for a weapon, but when I do so, it always results to true!

Hold attatched.

This is an old bug report that I can no longer reproduce. Also, the weapon here is using "Each use", but it should be using "Each attack". After changing this, then following the combat, the question is asked properly. (Questions cannot be asked in the middle of combat -- they must wait until after combat completes to be posed to the player.)

Marking this issue already fixed in 1.2 (probably in build 57). I'll respond to the Yes/No undo issue separately.

____________________________
Gandalf? Yes... That's what they used to call me. Gandalf the Grey. That was my name.
I am Gandalf the White. And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5415
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
Going to selfishly bump this because it turns out it's a bit of an issue in something I just tried to implement. Would be great to help add more flexibility to what you want pressing the command button to do.

Sorry, I'm not clear which of the three issues reported here is what you're referring to. Would you please clarify and post a barebones hold to reproduce the issue? Thanks!

Edit: is this the same issue you posted here?

____________________________
Gandalf? Yes... That's what they used to call me. Gandalf the Grey. That was my name.
I am Gandalf the White. And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 03-14-2016 06:42 AM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5415
Registered: 02-04-2003
IP: Logged

TFMurphy wrote:
EDIT: Tahnan's also found that it's impossible to undo past a Yes/No Question, so I'm adding that to the list of Question bugs in this thread.

I've added a workaround. Now pressing Esc on a yes/no question will undo the last move (rev 278). This would take a non-trivial amount of work to add full undo button+key support, and I'm going to defer that for now.

____________________________
Gandalf? Yes... That's what they used to call me. Gandalf the Grey. That was my name.
I am Gandalf the White. And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 3585
Registered: 07-11-2014
IP: Logged

File: Command question test.drh (1.4 KB)
Downloaded 47 times.
License: Public Domain

mrimer wrote:

kieranmillar wrote:
Going to selfishly bump this because it turns out it's a bit of an issue in something I just tried to implement. Would be great to help add more flexibility to what you want pressing the command button to do.

Sorry, I'm not clear which of the three issues reported here is what you're referring to. Would you please clarify and post a barebones hold to reproduce the issue? Thanks!

Edit: is this the same issue you posted here?

Apologies, I didn't actually quote the part I was talking about, which is this problem:

TFMurphy wrote: A Answer-based Question asked in a Cmd script fired via Each Use does *not* pause its execution when the Question is asked. As a result, whatever is immediately after the question is run first, no matter what the result of the Question is. Only on the turn after the Question does the correct result occur.

This is not the same as the issue in the other thread you linked to.

I have attached a test hold demonstrating the issue. When pressing the command key, you get given a choice of what type of key you want to gain, but it always ends up running the first choice and giving you a yellow key before the question pops up. (Choosing to gain a yellow key gives you a second one).

What should happen: lines of scripting after the Question command should not execute until the player actually answers the question.

EDIT: I just checked out of curiosity, and it seems the same bug occurs if you put the script into your accessory slot instead of the command slot, so it might be a problem with questions inside Each Use commands in general instead of explicitly an issue with the special command key.

---

[Last edited by kieranmillar at 03-14-2016 08:17 PM]

kieranmillar
Level: Smitemaster
Rank Points: 3585
Registered: 07-11-2014
IP: Logged

Can confirm in 1.2.6.283 that the results of mutli-choice questions inside globals or equipment/commands no longer pre-emptively execute following code before the question is answered.