skell
Level: Legendary Smitemaster

Rank Points: 3763
Registered: 12-28-2004
IP: Logged

Well, the thing is when I wanted to make more enemies and have them in one placed I named them for example AA_MON_Pizza_Roach (I like underscores). It looks bad when you right click the enemy (or even NPC) and see AA_MON_Pizza_Roach . So I have to name then normally, Pizza Roach. But then it is more difficult to find them, and if I wanted to do some change to all enemies there is a high chance I miss some of them.
That's where _MyName comes in! With this I could call my characters AA_MON_Pizza_Roach and the player would see the all beautiful Pizza Roach ^^.
(My linguistic skills are pretty low today so bear with me).

____________________________
My website

Sillyman
Level: Smiter

Rank Points: 339
Registered: 09-08-2006
IP: Logged

I approve of this request... but mostly because I want more per-character storage space.

____________________________
Who, me?
FNORD

12th Archivist
Level: Smitemaster

Rank Points: 789
Registered: 12-07-2008
IP: Logged

I would like bump this thread to nominate this request for the "Best Request of All Time Reward".

This would be so very useful, maybe even in official holds and TT's version of SMSs.

____________________________
It was going well until it exploded.
~Scott Manley

Check out the DROD Wikia project here!

kieranmillar
Level: Smitemaster
Rank Points: 2806
Registered: 07-11-2014
IP: Logged

Bumping this to ask for this PR https://github.com/CaravelGames/drod/pull/119 to be implemented in RPG

---

[Last edited by kieranmillar at 10-03-2020 01:19 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
Bumping this to ask for this PR https://github.com/CaravelGames/drod/pull/119 to be implemented in RPG

Sure! Kieren, would you feel comfortable translating that PR into the RPG codebase?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2806
Registered: 07-11-2014
IP: Logged

I guess I can give it a try.

EDIT: But I think I'll wait until the current patch is released, as that change is being held off until the 5.2 release.

---

[Last edited by kieranmillar at 10-06-2020 08:19 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
I guess I can give it a try.

EDIT: But I think I'll wait until the current patch is released, as that change is being held off until the 5.2 release.

Thank you! Sure, later is fine. There's a rpg-1.3-dev branch you can apply your PR to when you're ready to try this. If you have any questions about this, just ask.

Edit: I'm going to pick this one up now.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 11-25-2020 04:50 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

This was not as trivial to integrate as I'd first thought, as the code changes were based off some 5.x code that wasn't in the RPG codebase. I've pulled all the relevant bits over.

This will be in 1.3.

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2806
Registered: 07-11-2014
IP: Logged

I tried this out in 1.3.0.400, and it seems a difference in name is not one of the criteria used to distinguish a character from another on the battle screen.

I put a number of copies of a custom monster in the room (using regular script to set stats, not a default script), and then had one of the monsters have their name change via this variable. On the Battle screen, only the monster with the name change showed up, all of the other copies with identical stats but a different name did not display as a separate entry. Maybe that's fine, but not what I expected.

When I killed the one that had the _MyName variable change as its code, the battle screen went back to showing the name as the default all the other copies were using.

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

PR (thanks, hyperme!)


____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.