kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

File: BattleDialogTooBig.png (948.9 KB)
Downloaded 146 times.
License: Public Domain

When trying to specifically troll the dialog, even showing only 4 monsters at a time causes the dialog to break out of its allowed parent boundaries, which is the box where all the room tiles are drawn. This causes an assertion beep:

Assertion error in line 3375 of C:\Source Code\drod\drodrpg\DROD\GameScreen.cpp: "pStatsDialog->IsInsideOfParent()"




If figuring out how to calculate the height of each enemy's box is too tough, we could reduce it to a max of 3 enemies per page? 4 works most of the time when you aren't trying to troll things.

---

[Last edited by kieranmillar at 12-11-2022 07:11 PM]

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

File: BattleDialogSingleEntry.png (871.2 KB)
Downloaded 135 times.
License: Public Domain

But what if we were to go a level beyond trolling? I call it Trolling 2.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 1.3.0.499. Battle screen is now very good at splitting monsters off to another page appropriately.

I did some trolling around edge-cases and found that if you are maximally trying to troll the battle screen by making a character with a name of 12 capital Ws followed by a space all repeated for the maximum allowed length, and also all of the bonus effects added on at the end, then one character is itself too long for the window, but in that case the monster simply doesn't display. I don't think this particular edge-case is worth fixing as it is not realistic and the program appears to handle it fairly gracefully.