trick
Level: Legendary Smitemaster
Rank Points: 2580
Registered: 04-12-2003
IP: Logged

Me and a friend discovered some new and exciting editor bugs. All in 2.0.13, first two was tested in Linux and Windows versions.

* Copy/paste doesn't work for obstacles (ie rocks, bushes, etc). Copying a room section copies everything else, just not the obstacles. I'd expect the obstacles to get copied as well.

* Start placing a red serpent, and put down the first section, but don't finish it. Without finishing the red serpent, select a blue one, and return to the editor area. It now looks like you're placing a blue tail on the red serpent. This works the other way around as well. (This bug is purely cosmetic, the final serpent is the color you started with.)

I've also got some lines like this in drod.err:

Assertion error in line 432 of ../../DRODLib/CurrentGame.cpp: "this->bIsGameActive"
Assertion error in line 3107 of ../../DRODLib/CurrentGame.cpp: "this->bIsGameActive"

.. but these don't seem related to any of the above two bugs.

Also, my friend managed to crash DROD somehow (Windows version). He's been unable to reproduce it, though. The first time it crashed at playtesting, the second time when he deleted a script command ("Flush Speech"). Flush Speech was present in a character script at the time of the first crash as well, so that may be related, but I don't know. drod.err is blank (doesn't exist). Anyone else had editor crashes ?

(I don't have time to track these down at the moment, but I'll have a look later if noone else volunteered.)

- Gerry

Stefan
Level: Smitemaster

Rank Points: 2119
Registered: 05-25-2004
IP: Logged

trick wrote:
* Copy/paste doesn't work for obstacles (ie rocks, bushes, etc). Copying a room section copies everything else, just not the obstacles. I'd expect the obstacles to get copied as well.

This is actually documented. From the manual (Moving large regions):

Note: This operation is not supported for objects occupying more than one square (e.g. serpents and scenery).

____________________________
0.099³

trick
Level: Legendary Smitemaster
Rank Points: 2580
Registered: 04-12-2003
IP: Logged

Okay, but copying doesn't work for any obstacles -- not even 1x1 ones.

- Gerry

AlefBet
Level: Smitemaster
Rank Points: 979
Registered: 07-16-2003
IP: Logged

Because of the difficulty in implementing copying of general obstacles, obstacle copying was not implemented at all. In this case, the documentation is incomplete on that point, although I think it's a reasonable inference for someone to make. I've seen much worse flaws in documentation, even professional documentation of the dead tree variety.

That's not to say that obstacle copying (or serpent copying) might not be implemented for TCB or in the future, though.

____________________________
I was charged with conspiracy to commit jay-walking, and accessory to changing lanes without signaling after the fact .

++Adam H. Peterson

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

In addition, orbs have troubles when gates are modified or deleted. It retains the link to the square, so that if you delete a bound gate and then place a new gate in the bound square, it inherets the bindings. Also, sometimes if you link two or more gates together, the orb retains multiple bindings to the same gate and then carries them all out in sequence when struck. Easy to avoid, but still inconsistent and ugly. Orbs still work fine when manipulated.

Tahnan
Level: Smitemaster

Rank Points: 2459
Registered: 11-14-2005
IP: Logged

While we're at it, there are some annoying (though not fatal) inconsistencies with placing conflicting objects. For instance: you cannot place a potion on a square with a nonbreakable wall, but you can place a nonbreakable wall on a square with a potion. (In contrast, bombs and walls are incompatible in both directions.)

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

trick wrote:
* Start placing a red serpent, and put down the first section, but don't finish it. Without finishing the red serpent, select a blue one, and return to the editor area. It now looks like you're placing a blue tail on the red serpent. This works the other way around as well. (This bug is purely cosmetic, the final serpent is the color you started with.)

I've decided to fix this by enhancing the editor UI -- whenever you're editing a serpent, clicking on the other one in the menu will change the type of the serpent being edited.

I've also got some lines like this in drod.err:

Assertion error in line 432 of ../../DRODLib/CurrentGame.cpp: "this->bIsGameActive"
Assertion error in line 3107 of ../../DRODLib/CurrentGame.cpp: "this->bIsGameActive"

.. but these don't seem related to any of the above two bugs.

I can't track this one down myself. It happens every once in a while, but shouldn't cause any problems. If you can reproduce it consistently, I'll fix it.

Also, my friend managed to crash DROD somehow (Windows version). He's been unable to reproduce it, though. The first time it crashed at playtesting, the second time when he deleted a script command ("Flush Speech"). Flush Speech was present in a character script at the time of the first crash as well, so that may be related, but I don't know. drod.err is blank (doesn't exist). Anyone else had editor crashes ?

Maybe this is related to Doom's speech deletion-loss bug that caused a crash. I just fixed that one.

...there are some annoying (though not fatal) inconsistencies with placing conflicting objects. For instance: you cannot place a potion on a square with a nonbreakable wall, but you can place a nonbreakable wall on a square with a potion. (In contrast, bombs and walls are incompatible in both directions.)

I've fixed this so walls cannot be placed on potions. If there are other inconsistencies, just let me know and I'll fix 'em!

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 04-08-2006 07:07 PM]

Banjooie
Level: Smitemaster

Rank Points: 1645
Registered: 12-12-2004
IP: Logged

Question: There are holds with potions on unbreakable walls. Will this cause them to crash when this is fixed?

eytanz
Level: Smitemaster

Rank Points: 2708
Registered: 02-05-2003
IP: Logged

I'm pretty sure that the only thing that changes is the editor interface, not the data structure. So the behavior in existing holds won't change.

At least, that's what happened in similar changes in the past.

____________________________
I got my avatar back! Yay!