StuartK
Level: Smitemaster

Rank Points: 564
Registered: 06-10-2003
IP: Logged

Right clicking on DROD in task bar, and selecting close, does not exit DROD. Is this simply unimplimented?

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

StuartK wrote:
Right clicking on DROD in task bar, and selecting close, does not exit DROD. Is this simply unimplimented?

Yikes, I thought that worked...but I guess not.

Devs: I'm not sure what event SDL sends/receives this as. The event types we're watching now miss it. Anyone know?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

agaricus5
Level: Smitemaster
Rank Points: 1838
Registered: 02-04-2003
IP: Logged

mrimer wrote:

StuartK wrote:
Right clicking on DROD in task bar, and selecting close, does not exit DROD. Is this simply unimplimented?

Yikes, I thought that worked...but I guess not.

It seems to work for me in 2.0.10 - I can close DROD using both Alt+F4 and the "Close" function on the taskbar.

One thing that is a bit odd, though, is that the close function actually requires two clicks to close DROD, since doing it once only brings up the Danforth Strout screen; you need to do it again to quit properly. Alt+F4, on the other hand, closes DROD immediately, which is more intuitive - perhaps the close function should also end DROD immediately.

____________________________
Resident Medic/Mycologist

Banjooie
Level: Smitemaster

Rank Points: 1645
Registered: 12-12-2004
IP: Logged

agaricus: wouldn't that sort of make it so noone saw the Danforth Strout screen, 90% of the time?

eytanz
Level: Smitemaster

Rank Points: 2708
Registered: 02-05-2003
IP: Logged

Banjooie wrote:
agaricus: wouldn't that sort of make it so noone saw the Danforth Strout screen, 90% of the time?

And that would be bad because?

____________________________
I got my avatar back! Yay!

patmo98
Level: Delver
Rank Points: 39
Registered: 03-14-2003
IP: Logged

eytanz wrote:
And that would be bad because?

I agree with you, I wish there was a "don't show this page again" checkbox. At least for people who bought it.

AlefBet
Level: Smitemaster
Rank Points: 979
Registered: 07-16-2003
IP: Logged

I don't know why people are so concerned about streamlining the "close" button on the main menu when you can easily leave the game by pressing Escape. In fact, whenever I want to quit from just about anywhere in the game, I just mash Escape three or four times and I'm out without any nag screen or anything.

____________________________
I was charged with conspiracy to commit jay-walking, and accessory to changing lanes without signaling after the fact .

++Adam H. Peterson

eytanz
Level: Smitemaster

Rank Points: 2708
Registered: 02-05-2003
IP: Logged

AlefBet wrote:
I don't know why people are so concerned about streamlining the "close" button on the main menu when you can easily leave the game by pressing Escape. In fact, whenever I want to quit from just about anywhere in the game, I just mash Escape three or four times and I'm out without any nag screen or anything.

On a windows system? For me, the Danforth Strout screen takes about 15-20 seconds to load, making exiting by pressing ESC quite annoying.

____________________________
I got my avatar back! Yay!

Oneiromancer
Level: Legendary Smitemaster

Rank Points: 2936
Registered: 03-29-2003
IP: Logged

eytanz wrote:
On a windows system? For me, the Danforth Strout screen takes about 15-20 seconds to load, making exiting by pressing ESC quite annoying.

Odd. I use Windows, and Escape never takes me to the Danforth Strout screen. In order to get there I have to choose the Exit Game option or click on the red X if I'm playing in windowed mode. Escape takes me right out, just as Adam says.

Game on,

____________________________
"He who is certain he knows the ending of things when he is only beginning them is either extremely wise or extremely foolish; no matter which is true, he is certainly an unhappy man, for he has put a knife in the heart of wonder." -- Tad Williams

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

eytanz wrote:
On a windows system? For me, the Danforth Strout screen takes about 15-20 seconds to load, making exiting by pressing ESC quite annoying.

I confirm: Escape has never gone to Danforth's place. It's always been the "boss" key. Either you're just assuming this, or you must have one o' those jiggy builds that crawled out of some primeval swamp. Also...a single screen takes me about one second to load. If it takes 20 seconds for you, then why, oh, why have you never reported this as something that should probably be fixed?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 10-26-2005 09:23 PM]

StuartK
Level: Smitemaster

Rank Points: 564
Registered: 06-10-2003
IP: Logged

Back to the original topic, I can confirm that close from the taskbar definitely doesn't work for me, though Alt+F4 does. Ummm. XP SP2, nothing unusual about my machine I think.

As far as delays (in general) and speaking for myself, patience (or a penchent for opportunities to drift gently in space) and possibly a misapprehension that other people are putting up with exactly the same delays and are quite happy with them.

My own personal opinion of the Danforth Strout screen can be illustrated by this short biographical story;

When I was about 8 years old, I had a teacher I really liked, and one joke which endlessly amused me, and which I told over and over and over again. My teacher left the school the next year, and I wonder to this day whether these two things were related.

eytanz
Level: Smitemaster

Rank Points: 2708
Registered: 02-05-2003
IP: Logged

mrimer wrote:

eytanz wrote:
On a windows system? For me, the Danforth Strout screen takes about 15-20 seconds to load, making exiting by pressing ESC quite annoying.

I confirm: Escape has never gone to Danforth's place. It's always been the "boss" key. Either you're just assuming this, or you must have one o' those jiggy builds that crawled out of some primeval swamp. Also...a single screen takes me about one second to load. If it takes 20 seconds for you, then why, oh, why have you never reported this as something that should probably be fixed?

Because everything is slow on this computer system, not just DROD. So I'm assuming the problem isn't with DROD. My other computers that have DROD on them work a lot faster.

That said, I do get the Danforth screen upon pressing ESC. I just tested and it came up. It doesn't always come up when I press ESC - it depends on what screen I'm in when I start pressing the series of ESCs. I'll investigate this further and let you know.

____________________________
I got my avatar back! Yay!

agaricus5
Level: Smitemaster
Rank Points: 1838
Registered: 02-04-2003
IP: Logged

AlefBet wrote:
I don't know why people are so concerned about streamlining the "close" button on the main menu when you can easily leave the game by pressing Escape.

I thought we were talking about the "Close" option obtained by right-clicking DROD on the taskbar. In any case, if you do that, the option says:

X Close Alt+F4

...which suggests that it has the same function as Alt+F4, although it doesn't (on my computer). Anyway, I would like to be able to close it directly using this function, since it is the only way I can do it without opening up the DROD window and using Task Manager to do it manually. Occasionally I overload my computer with Excel or related programs (trying to do 5 things at once), and so want to close DROD quickly just in case the whole OS fails (which hasn't happened yet, but it could), and without having to bring up another window onto an already frozen one.

____________________________
Resident Medic/Mycologist

Chris
Level: Master Delver
Rank Points: 144
Registered: 08-12-2005
IP: Logged

For what it's worth, in Linux running GNOME, both right-clicking on the task bar icon and chosing 'close' and hitting alt-f4 take me to the saleman's screen.

trick
Level: Legendary Smitemaster
Rank Points: 2580
Registered: 04-12-2003
IP: Logged

Closing the window via the taskbar should make SDL send an SDL_QUIT event to DROD, just like closing a window via its close button does. Do closing the DROD window via the window close button and via the taskbar behave differently ? (I'd check it myself, but I can't test/look at the code right now)

- Gerry

---

[Last edited by trick at 10-27-2005 10:47 PM : never mind alt-f4]

Chris
Level: Master Delver
Rank Points: 144
Registered: 08-12-2005
IP: Logged

Not for me, no.

Clicking the window's close button (the 'X' in the top right corner) also shows me the salesman screen, as does clicking on 'Quit' in the main menu, or pressing the 'q' key in the main menu.

The only inconsistancy is that hitting the escape key in the main menu quits immediately, bypassing the salesman. This, of course, is a Godsend.

(TitleScreen.cpp has this code - so it's intentional that ESC quits directly:

case SDLK_ESCAPE:
//Pressing ESC will quit without confirmation dialog from the main menu.
if (this->pMenu->IsVisible())
GoToScreen(SCR_None);
)

I guess the question is really whether agaricus5's computer really behaves differently when it gets an alt-f4 and when he right-clicks on the taskbar icon and chooses 'quit' or 'close' or whatever windose calls it.

agaricus5
Level: Smitemaster
Rank Points: 1838
Registered: 02-04-2003
IP: Logged

Chris wrote:
I guess the question is really whether agaricus5's computer really behaves differently when it gets an alt-f4 and when he right-clicks on the taskbar icon and chooses 'quit' or 'close' or whatever windose calls it.

Well, in the actual game itself, it quits automatically (from everywhere I've tested it) if "Alt+F4" is pressed, but in the taskbar, right-clicking DROD and then pressing "Close" brings up the Danforth Strout screen first (you have to re-activate DROD to see it, though).

I am using Windows XP Service Pack 2 (I think), and am using a version of DROD that was probably a Beta version (Build 20) patched to 2.0.0.1, then 2.0.4, 2.0.5, 2.0.7, 2.0.8 and then 2.0.10. It could be that this may be why I'm getting different results to the rest of you, although it sounds a bit strange.

____________________________
Resident Medic/Mycologist

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

trick wrote:
Closing the window via the taskbar should make SDL send an SDL_QUIT event to DROD, just like closing a window via its close button does. Do closing the DROD window via the window close button and via the taskbar behave differently ? (I'd check it myself, but I can't test/look at the code right now)

I've tried this out in debug mode, and on my computer right-click and Close do not cause an SDL_QUIT event to fire. At least, the EventHandlerWidget's loop is not catching one. I think this used to work. DROD:AE, for example, does try to close if I do this on my computer. Maybe there's a problem with signalling quit for this in SDL 1.2.8/9?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

StuartK
Level: Smitemaster

Rank Points: 564
Registered: 06-10-2003
IP: Logged

I've been doing some more investigating, and what I'm seeing now, is that right clicking on the taskbar and closing only works some of the time for me. Say 1 out of 5 or 10 attempts, after which I get Danforth Strout again. Strange indeedy...

michthro
Level: Smitemaestro
Rank Points: 679
Registered: 05-01-2005
IP: Logged

StuartK wrote:
I've been doing some more investigating, and what I'm seeing now, is that right clicking on the taskbar and closing only works some of the time for me. Say 1 out of 5 or 10 attempts, after which I get Danforth Strout again. Strange indeedy...

I think the problem is that SDL receives an SDL_ACTIVEEVENT before the SDL_QUIT, but CEventHandlerWidget::OnActiveEvent cleans up the message queue before returning. I added

do if (SDL_PeepEvents(&event, 1, SDL_PEEKEVENT, SDL_QUITMASK)) break;

before

while (SDL_PollEvent(&event)) ;

and this seems to work. I suppose the quit message sometimes only arrives after the cleanup, which would explain the strange behaviour.

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

michthro wrote:
I think the problem is that SDL receives an SDL_ACTIVEEVENT before the SDL_QUIT, but CEventHandlerWidget::OnActiveEvent cleans up the message queue before returning. I added

do if (SDL_PeepEvents(&event, 1, SDL_PEEKEVENT, SDL_QUITMASK)) break;

before

while (SDL_PollEvent(&event)) ;

and this seems to work. I suppose the quit message sometimes only arrives after the cleanup, which would explain the strange behaviour.

Ah, very good. This fix works for me too, so I'll include it in the next patch. Thanks!

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.