Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (5.1.1 Issue)
New Topic New Poll Post Reply
Poster Message
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged

File: BeepGif.gif (195.8 KB)
Downloaded 303 times.
License: Public Domain
icon Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+2)  
Guards with daggers will step on characters which have imperative invulnerable OR imperative pushable by weapon, without killing them and will produce a beep.

I have discovered it as part of the effort to make tests work again, I'll fix this.

Affects the new 5.1.1 alpha



____________________________
My website | Facebook | Twitter
09-29-2020 at 09:52 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged

File: BUG REPORT Guard Daggers on Characters.hold (1 KB)
Downloaded 20 times.
License: Public Domain
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Attached example hold.

____________________________
My website | Facebook | Twitter
09-29-2020 at 09:53 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+5)  
09-29-2020 at 10:50 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Good news, in 5.1.1.alpha.2020-10-16, an invulnerable character and a pushable by weapon character both could not be stepped on by a dagger guard.

Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

[Last edited by kieranmillar at 10-17-2020 02:31 PM]
10-17-2020 at 02:29 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+2)  
kieranmillar wrote:
Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

PR

____________________________
My website | Facebook | Twitter
10-17-2020 at 09:34 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (0)  
kieranmillar wrote: Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.
Still happening in 5.1.1.alpha.2020-10-18, for whatever its worth, not sure if this change made it into that alpha or not.
10-18-2020 at 03:30 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (0)  
kieranmillar wrote:
kieranmillar wrote: Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.
Still happening in 5.1.1.alpha.2020-10-18, for whatever its worth, not sure if this change made it into that alpha or not.
I pulled all the merged PRs and rebuilt, so this PR should be included in my latest dev build. Seems like a(nother) fix needs to be applied.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 10-18-2020 03:38 PM]
10-18-2020 at 03:37 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (0)  
I have a test for brain-role character, but maybe the issue is with naturally invulnerable roles, eg citizen

____________________________
My website | Facebook | Twitter
10-18-2020 at 04:35 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (0)  
My test uses a Citizen.
10-18-2020 at 04:37 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+2)  
kieranmillar wrote:
My test uses a Citizen.

Your test case is my test case. PR

____________________________
My website | Facebook | Twitter
10-18-2020 at 09:00 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Can confirm in 5.1.1.alpha.2020-10-29 that the dagger guard does not step on top of a vulnerable character, but instead kills it.

I note that unlike the player, the guard is not really doing a proper body kill and does not immediately occupy the space the killed character was on, but that's probably fine?
10-31-2020 at 06:20 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (0)  
kieranmillar wrote:
Can confirm in 5.1.1.alpha.2020-10-29 that the dagger guard does not step on top of a vulnerable character, but instead kills it.

I note that unlike the player, the guard is not really doing a proper body kill and does not immediately occupy the space the killed character was on, but that's probably fine?

Actually the fact that player can dagger step on vulnerable character citizens is a bug - incorrect variable is passed to a function that checks if a given monster type can be dagger stepped. So I can:
1. Fix it for the player
2. Make other monsters consistent with the player
3. Leave it as-is

Thoughts?

____________________________
My website | Facebook | Twitter
11-01-2020 at 08:34 PM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Personally I'd go with option 2. The dagger allowing body kills unless the monster leaves a blocking corpse is how I imagine many people interpret the dagger's behaviour.

If you are a monster player role you can body kill a vulnerable citizen character no problem, so I'd expect dagger-wielding entities to do the same.
11-01-2020 at 08:38 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Okay I will fix this bug by using solution #2 and I hope it won't break many demos!

____________________________
My website | Facebook | Twitter
11-03-2020 at 12:16 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+2)  
PR

____________________________
My website | Facebook | Twitter
11-03-2020 at 11:29 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2668
Registered: 07-11-2014
IP: Logged
icon Re: Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (+1)  
Can confirm fixed in 5.1.1.alpha.2020-11-04.
11-07-2020 at 11:45 AM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : Guards with daggers enjoy merging with invulnerable/pushable by weapon characters (5.1.1 Issue)
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.