skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

File: BeepGif.gif (195.8 KB)
Downloaded 328 times.
License: Public Domain

Guards with daggers will step on characters which have imperative invulnerable OR imperative pushable by weapon, without killing them and will produce a beep.

I have discovered it as part of the effort to make tests work again, I'll fix this.

Affects the new 5.1.1 alpha



____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

File: BUG REPORT Guard Daggers on Characters.hold (1 KB)
Downloaded 44 times.
License: Public Domain

Attached example hold.

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

PR: https://github.com/CaravelGames/drod/pull/69

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

Good news, in 5.1.1.alpha.2020-10-16, an invulnerable character and a pushable by weapon character both could not be stepped on by a dagger guard.

Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

---

[Last edited by kieranmillar at 10-17-2020 02:31 PM]

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

kieranmillar wrote:
Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

PR

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

kieranmillar wrote: Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

Still happening in 5.1.1.alpha.2020-10-18, for whatever its worth, not sure if this change made it into that alpha or not.

mrimer
Level: Legendary Smitemaster

Rank Points: 5195
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:

kieranmillar wrote: Bad news, I initially set a character to have imperative vulnerable instead by accident, and this character was totally stepped on and produced an error beep.

Still happening in 5.1.1.alpha.2020-10-18, for whatever its worth, not sure if this change made it into that alpha or not.

I pulled all the merged PRs and rebuilt, so this PR should be included in my latest dev build. Seems like a(nother) fix needs to be applied.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 10-18-2020 03:38 PM]

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

I have a test for brain-role character, but maybe the issue is with naturally invulnerable roles, eg citizen

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

My test uses a Citizen.

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

kieranmillar wrote:
My test uses a Citizen.

Your test case is my test case. PR

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

Can confirm in 5.1.1.alpha.2020-10-29 that the dagger guard does not step on top of a vulnerable character, but instead kills it.

I note that unlike the player, the guard is not really doing a proper body kill and does not immediately occupy the space the killed character was on, but that's probably fine?

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

kieranmillar wrote:
Can confirm in 5.1.1.alpha.2020-10-29 that the dagger guard does not step on top of a vulnerable character, but instead kills it.

I note that unlike the player, the guard is not really doing a proper body kill and does not immediately occupy the space the killed character was on, but that's probably fine?

Actually the fact that player can dagger step on vulnerable character citizens is a bug - incorrect variable is passed to a function that checks if a given monster type can be dagger stepped. So I can:
1. Fix it for the player
2. Make other monsters consistent with the player
3. Leave it as-is

Thoughts?

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

Personally I'd go with option 2. The dagger allowing body kills unless the monster leaves a blocking corpse is how I imagine many people interpret the dagger's behaviour.

If you are a monster player role you can body kill a vulnerable citizen character no problem, so I'd expect dagger-wielding entities to do the same.

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

Okay I will fix this bug by using solution #2 and I hope it won't break many demos!

____________________________
My website

skell
Level: Legendary Smitemaster

Rank Points: 3775
Registered: 12-28-2004
IP: Logged

PR

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 3143
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 5.1.1.alpha.2020-11-04.