uncopy2002
Level: Smiter
Rank Points: 431
Registered: 07-28-2014
IP: Logged

File: Bridge building horror.hold (1.5 KB)
Downloaded 50 times.
License: Public Domain

Demo hold attached.

When building a whole area of bridges via build command, very weird things that defy intuition happen:

1. Bridge dropping checks does not consider for tiles that have changed during the turn, e.g builders or build command, even though the check should be at post-turn.

2. Building over an area is performed by building every single tile from up to down, left to right. However, bridge connectivity checks are performed each time a tile of bridge is built, which means depending on where your support tile are, part of the bridge you built will drop while other remains.

3. Bridge dropping checks and water/pit checks are not performed at the same time. Bridges can drop around other dropped bridges and, as a result, form into water, which makes no sense at all.

And then I don't even anymore.


There's definitely at least one bug inside all this mess.

---

[Last edited by uncopy2002 at 04-15-2016 07:04 PM]

skell
Level: Legendary Smitemaster

Rank Points: 3764
Registered: 12-28-2004
IP: Logged

Now bridges state is updated only after the whole build command is processed. Related topic. PR

Please please, if there are any known holds that use build or build markers with bridges - test them.

____________________________
My website

---

[Last edited by mrimer at 11-04-2020 07:29 PM : fix link]

kieranmillar
Level: Smitemaster
Rank Points: 2842
Registered: 07-11-2014
IP: Logged

I took a look at the example hold in 5.1.1.alpha.2020-10-29 but there are still bugs/questions.

1) When a bridge is built, dropping occurs immediately after build if it is not connected to anything. So if you make two separate build commands, one attached to ground, and the other attached only to the bridge you just built, you get a stable structure. Put the build commands the other way around and the initially unconnected bridge will fall. Perhaps this is fine.

2) If a bridge is due to fall on turn 1 because it is initially unconnected on turn 0, and you try to build a bridge on top of it on turn 1, the falling bridge will turn that tile into water, even if it is in the middle of a pit. See the original example hold.

skell
Level: Legendary Smitemaster

Rank Points: 3764
Registered: 12-28-2004
IP: Logged

PR

It is now possible to save bridges from falling if a new support is added to them before the end of the turn. Should fix all other weird edge cases that Kieran has found.

____________________________
My website

kieranmillar
Level: Smitemaster
Rank Points: 2842
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 5.1.1.alpha.2020-11-04. Build order no longer matters for bridges when you build multiple in a turn (including trapdoors). And bridges that were destined to fall no longer bizarrely turn into water.