Lucky Luc
Level: Smitemaster
Rank Points: 1215
Registered: 08-19-2012
IP: Logged

File: Custom Shield Oddity.drh (1.3 KB)
Downloaded 43 times.
License: Public Domain

So I guess there haven't been any holds with custom shields yet?

Tested with the current release candidate (1.2.6.241).

Attached is a small demo hold using silly custom equipment: A sword that says hi and breaks on its first use, as well as a shield, which does the same and additionally builds some stuff.

This works as expected when fighting a monster. However, try to right-click on a monster and wait one move:

- the shield gets destroyed, but its name sticks around in the inventory
- the northern mud baby gets killed, but there's no visuals
- the bomb gets blown up, but again, no visuals.

Note that the room visuals are fixed when leaving and reentering the room.

Pressing + is even worse: The game will simply crash.

Expected behavior: Each Defend should not be triggered at all on checking monster stats.

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

Thanks for the report and the sample hold. Makes the issue so easy to reproduce and test!

Fixed in rev 276. "Each attack/defend" shouldn't get executed while calculating projected fight resolution. There was an "Each defend" case that was missing for the player's armor.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm that the provided test hold in the original post works great in 1.2.6.278

Did notice a different bug that I first mentioned in anohter thread that this hold ends up being a good test case for: http://forum.caravelgames.com/viewtopic.php?TopicID=40876&page=0#404766