Mazer
Level: Master Delver
Rank Points: 162
Registered: 04-08-2007
IP: Logged

When black gates toggle, there is no sound coming from them. All other gates work fine.

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

The toggle sound comes from the CID_AllTarRemoved event... I suspect that preventing the "All tar removed" event from firing on a black gate rising also prevents the sound.

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

coppro wrote:
The toggle sound comes from the CID_AllTarRemoved event... I suspect that preventing the "All tar removed" event from firing on a black gate rising also prevents the sound.

Probably so. Would you tell me in what specific situation this occurs?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 04-07-2008 04:51 PM]

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

GameScreen.cpp, around line 3075 in CGameScreen:rocessCueEventsBeforeRoomDraw, the sound for a door opening is played if any of CID_AllTrapdoorsRemoved, CID_RoomConquerPending, or CID_AllTrapdoorsRemoved is triggered.

Also, CID_AllTrapdoorsRemoved is also triggered when a trapdoor is added, in CDbRoom::IncTrapdoor. I would recommend creating two new cue events, associated triggers for script, and triggers for the sounds. It's the only way that doesn't whack backwards-compatibility over the head with a large stick.

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

coppro wrote:
GameScreen.cpp, around line 3075 in CGameScreen:rocessCueEventsBeforeRoomDraw, the sound for a door opening is played if any of CID_AllTrapdoorsRemoved, CID_RoomConquerPending, or CID_AllTrapdoorsRemoved is triggered.

I ssume you mean AllTarRemoved here, since Mazer is talking about black gates. If you recall, this should have been fixed by me for build 74. If it's still not working with build 74, I need a specific simple example hold that demonstrates the bug.

Also, CID_AllTrapdoorsRemoved is also triggered when a trapdoor is added, in CDbRoom::IncTrapdoor. I would recommend creating two new cue events, associated triggers for script, and triggers for the sounds. It's the only way that doesn't whack backwards-compatibility over the head with a large stick.

That's true. I'll fix this so AllTrapdoorsRemoved does not fire when a trapdoor is added to a room w/o trapdoors in build 75.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

coppro
Level: Smitemaster
Rank Points: 1308
Registered: 11-24-2005
IP: Logged

mrimer wrote:

coppro wrote:
GameScreen.cpp, around line 3075 in CGameScreen:rocessCueEventsBeforeRoomDraw, the sound for a door opening is played if any of CID_AllTrapdoorsRemoved, CID_RoomConquerPending, or CID_AllTrapdoorsRemoved is triggered.

I ssume you mean AllTarRemoved here, since Mazer is talking about black gates. If you recall, this should have been fixed by me for build 74. If it's still not working with build 74, I need a specific simple example hold that demonstrates the bug.

It was a typo. The third should be CID_AllTarRemoved. But as I haven't seen the code and I'm not on Windows, I can't tell you whether the sound was changed. I'm thinking that if you made CID_AllTarRemoved not fire when black gates are raised, then there will not be a sound. Similarly for trapdoors.

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

coppro wrote:

mrimer wrote:

coppro wrote:
GameScreen.cpp, around line 3075 in CGameScreen:rocessCueEventsBeforeRoomDraw, the sound for a door opening is played if any of CID_AllTrapdoorsRemoved, CID_RoomConquerPending, or CID_AllTrapdoorsRemoved is triggered.

I ssume you mean AllTarRemoved here, since Mazer is talking about black gates. If you recall, this should have been fixed by me for build 74. If it's still not working with build 74, I need a specific simple example hold that demonstrates the bug.

It was a typo. The third should be CID_AllTarRemoved. But as I haven't seen the code and I'm not on Windows, I can't tell you whether the sound was changed. I'm thinking that if you made CID_AllTarRemoved not fire when black gates are raised, then there will not be a sound. Similarly for trapdoors.

Right. Which is why I'm requesting the poster of this bug report provide some evidence that build 74 has this bug.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

TFMurphy
Level: Smitemaster
Rank Points: 3118
Registered: 06-11-2007
IP: Logged

For the record, it's happening on both basic toggles of the black gate. If you create a room with a Black Gate, a blob of Mud, and a Mud Mother on no mud, then the gate will toggle when the blob is destroyed, and then toggle again when the Mud Mother grows. On both events, there is no sound from the Black Gate toggle.

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

TFMurphy wrote:
For the record, it's happening on both basic toggles of the black gate. If you create a room with a Black Gate, a blob of Mud, and a Mud Mother on no mud, then the gate will toggle when the blob is destroyed, and then toggle again when the Mud Mother grows. On both events, there is no sound from the Black Gate toggle.

I found the reason for this. It'll be fixed in build 75.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.