Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : Not sure if it's a bug...
New Topic New Poll Post Reply
Poster Message
Malarame
Level: Master Delver
Rank Points: 220
Registered: 02-04-2003
IP: Logged
icon Not sure if it's a bug... (0)  
On the restore screen, when I scroll the mouse wheel in the list of levels, instead of scrolling the list it acts as though I clicked on the level my mouse is over. I\'m not sure if that was intended, but I think that the list should scroll when I scroll my mouse wheel.

____________________________
Matt O'Leary
Webb Institute
Class of 2007

"I never forget a face, but in your case I'll be glad to make an exception."
-Groucho Marx
03-24-2003 at 05:01 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts Quote Reply
ErikH2000
Level: Legendary Smitemaster
Avatar
Rank Points: 2794
Registered: 02-04-2003
IP: Logged
icon Re: Not sure if it's a bug... (0)  
Malarame wrote:
On the restore screen, when I scroll the mouse wheel in the list of levels, instead of scrolling the list it acts as though I clicked on the level my mouse is over. I\'m not sure if that was intended, but I think that the list should scroll when I scroll my mouse wheel.
I\'m going to add \"test with mousewheel\" to our tasks. Since we\'ve got this SDL library in between DROD and the operating system, we may never get any real support for mousewheel usage. However, a useful change may present itself once the issue is looked at. Thanks for the input, Matt.

-Erik


____________________________
The Godkiller - Chapter 1 available now on Steam. It's a DROD-like puzzle adventure game.
dev journals | twitch stream | youtube archive (NSFW)
03-31-2003 at 01:06 AM
View Profile Send Email to User Show all user's posts This architect's holds Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5381
Registered: 02-04-2003
IP: Logged
icon Re: Not sure if it's a bug... (0)  
cvs diff ListBoxWidget.cpp (in directory E:\\schikore\\priv\\Caravel\\DROD)
Index: ListBoxWidget.cpp
===================================================================
RCS file: /cvsroot/drod/Caravel/DROD/ListBoxWidget.cpp,v
retrieving revision 1.24
diff -r1.24 ListBoxWidget.cpp
332,337c332,340
< ASSERT(this->eLastClickResult == LBCR_Nothing);
< this->eLastClickResult = ClickAtCoords(MouseButtonEvent.x, MouseButtonEvent.y);
< switch (this->eLastClickResult)
< {
< case LBCR_Nothing:
< return; //No changes to paint.
---
> if (MouseButtonEvent.button == 4) ScrollUpOneLine();
> else if (MouseButtonEvent.button == 5) ScrollDownOneLine();
> else {
> ASSERT(this->eLastClickResult == LBCR_Nothing);
> this->eLastClickResult = ClickAtCoords(MouseButtonEvent.x, MouseButtonEvent.y);
> switch (this->eLastClickResult)
> {
> case LBCR_Nothing:
> return; //No changes to paint.
339,341c342,344
< case LBCR_UpButton:
< this->bIsUpButtonPressed = true;
< break;
---
> case LBCR_UpButton:
> this->bIsUpButtonPressed = true;
> break;
343,345c346,348
< case LBCR_DownButton:
< this->bIsDownButtonPressed = true;
< break;
---
> case LBCR_DownButton:
> this->bIsDownButtonPressed = true;
> break;
347,348c350,352
< default:
< break;
---
> default:
> break;
> }


***** CVS exited normally with code 1 *****


____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
04-09-2003 at 06:55 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Fixing the listbox widget (0)  
This looks like a nice, simple fix. I think we should also have a more general solution to this problem, i.e., in the CEventHandlerWidget, keep track of which button is being pressed. We already do this now for distinguishing the right mouse button, so this will be simple. Then handle the button behavior accordingly in the subclasses. (This will prevent scrolling the wheel while the mouse cursor is over check boxes toggling their setting, etc.)

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
04-17-2003 at 08:49 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Re: Not sure if it's a bug... (0)  
diff -r1.24 ListBoxWidget.cpp
332,337c332,340
< ASSERT(this->eLastClickResult == LBCR_Nothing);
< this->eLastClickResult = ClickAtCoords(MouseButtonEvent.x, MouseButtonEvent.y);
< switch (this->eLastClickResult)
...
Could you print out your diffs with the \"-w -u\" flags set? This will make it a lot easier to read and update.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
04-17-2003 at 08:51 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5381
Registered: 02-04-2003
IP: Logged
icon Re: Re: Fixing the listbox widget (0)  
Well, since I saw the task added to SF, I went ahead and checked in the change as-is. Whenever the code is changed as you\'ve suggested, this will have to be changed as well. No biggie.


____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
04-17-2003 at 08:52 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5381
Registered: 02-04-2003
IP: Logged
icon Re: Re: Re: Not sure if it's a bug... (0)  
mrimer wrote:
Could you print out your diffs with the \"-w -u\" flags set? This will make it a lot easier to read and update.
I just tried this to see what it was, and my cvs tells me it\'s invalid?

Usage: cvs diff [-lNR] [rcsdiff-options]
[[-r rev1 | -D date1] [-r rev2 | -D date2]] [files...]
-l Local directory only, not recursive
-R Process directories recursively.
-D d1 Diff revision for date against working file.
-D d2 Diff rev1/date1 against date2.
-N include diffs for added and removed files.
-r rev1 Diff revision for rev1 against working file.
-r rev2 Diff rev1/date1 against rev2.
--ifdef=arg Output diffs in ifdef format.


____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
04-17-2003 at 08:54 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Re: Re: Re: Not sure if it's a bug... (0)  
Schik wrote:
I just tried this to see what it was, and my cvs tells me it\'s invalid?
Uh, yeah...I don\'t see it on there either. But if I do, for example:

cvs ... diff -w -u DRODLib\\*.cpp

This shows a nicer view (credit to Erik for this hint).

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
04-17-2003 at 09:04 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5056
Registered: 02-04-2003
IP: Logged
icon Re: Re: Re: Fixing the listbox widget (0)  
Schik wrote:
Well, since I saw the task added to SF, I went ahead and checked in the change as-is.
No, that\'s great. It works like a charm! I\'ll check in the other part soon.


____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
04-17-2003 at 09:12 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5381
Registered: 02-04-2003
IP: Logged
icon Re: Re: Re: Re: Re: Not sure if it's a bug... (0)  
mrimer wrote:
Uh, yeah...I don\'t see it on there either. But if I do, for example:

cvs ... diff -w -u DRODLib\\*.cpp

This shows a nicer view (credit to Erik for this hint).
What I pasted above is what cvs tells me when I try cvs diff -w -u ...

This is using WinCVS, which I\'m new at - I usually just use command line cvs.

____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
04-17-2003 at 09:35 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5381
Registered: 02-04-2003
IP: Logged
icon Re: Not sure if it's a bug... (0)  
By the way, DUH! In the WinCVS diff window, there are checkboxes for Unified Diff and Ingore Whitespace, both right in front of my face. They work fine, so I'll use them in the future.

____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
05-01-2003 at 07:40 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : Not sure if it's a bug...
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.