kieranmillar
Level: Smitemaster
Rank Points: 2860
Registered: 07-11-2014
IP: Logged

File: BUG REPORTPlayer Role None Tween.drh (762 bytes)
Downloaded 48 times.
License: Public Domain

Note: I could not replicate the following in regular DROD so I can only assume this as an RPG-specific bug. It also happens on the last stable version, so not related to skell's rendering changes.

If you start a room as Player Role None (because you were moved to another room during a cutscene as the player can only be this player role during a cutscene), if you restart the new room by pressing R, the player motion-tweens back to their starting spot instead of snapping to that position instantly.

See attached example hold. Once the cutscene ends, move a bit then press R.

---

[Last edited by kieranmillar at 10-30-2020 10:52 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5148
Registered: 02-04-2003
IP: Logged

Thanks, Kieran.

I'm running into a blocking bug before I can investigate this issue, it seems. When I import the attached hold, I'm getting an assertion failure beep that the NPC in the room has no script attached to it.

IIRC, this happened on another test hold I imported from you, where there was only a default script defined for a custom NPC. There may be a regression in 1.2.8. I'll investigate further. Stay tuned.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5148
Registered: 02-04-2003
IP: Logged

Yes...I believe that any exports you've been performing in 1.2.8 have been losing (i.e., not writing out) NPC parameters and scripts. I think this is a regression.

Edit: Yes, it is. I've created a separate topic to track that.

I'm putting up a new dev build that fixes this (2020-10-30). Would you please export your test hold for this topic again using the new dev build?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 10-31-2020 03:15 AM]

kieranmillar
Level: Smitemaster
Rank Points: 2860
Registered: 07-11-2014
IP: Logged

File: BUG REPORTPlayer Role None Tween.drh (1 KB)
Downloaded 49 times.
License: Public Domain

Here's the hold again, exported from the most recent alpha.

mrimer
Level: Legendary Smitemaster

Rank Points: 5148
Registered: 02-04-2003
IP: Logged

Thank you. Fixed!

PR

Typically, a "wait" command is executed implicitly on room entrance, which gets the player situated properly. This wasn't happening when reverting from a Player Role None situation.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2860
Registered: 07-11-2014
IP: Logged

File: BUG REPORTPlayer Role None Tween 2.drh (1.1 KB)
Downloaded 47 times.
License: Public Domain

Turns out there's a little more going on with this bug.

The above fix works... if the player role is reverted back to the default role automatically when the cutscene ends.

However, if you change the player role to something else immediately upon entering the next room after the level transition, the tweening still happens.

See new example hold.

---

[Last edited by kieranmillar at 11-10-2020 10:00 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5148
Registered: 02-04-2003
IP: Logged

Thank you.

Seems there was a fix in 5.1 or earlier that didn't make it over to RPG.

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2860
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 1.2.8.build323