Announcement: Be excellent to each other.


Caravel Forum : DROD RPG Boards : RPG Bugs : Regression: Wall shadows on platform over pit flickering
New Topic New Poll Post Reply
Poster Message
kieranmillar
Level: Smitemaster
Rank Points: 2273
Registered: 07-11-2014
IP: Logged

File: BUG REPORT Platform shadows.drh (856 bytes)
Downloaded 6 times.
License: Public Domain
icon Regression: Wall shadows on platform over pit flickering (+2)  
See attached example hold.

When room darkness is zero so shadows are enabled, the shadows flicker in and out of existence sometimes.

This is best seen by playesting the rooms in the editor. Swapping between rooms sometimes also causes shadows to start flickering.

[Last edited by kieranmillar at 11-22-2020 03:12 PM]
11-22-2020 at 03:11 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
This is in version 1.2.8.345, correct?

I'm not able to reproduce any flickering in my current build.

I've tried in the editor, in windowed and full screen, and when setting the repeat rate to slow, medium, and fast.

Can you provide more steps to reproduce?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
11-23-2020 at 02:08 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2273
Registered: 07-11-2014
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (+5)  
mrimer wrote:
This is in version 1.2.8.345, correct?
Yes.

In the absence of being able to figure out a consistent set of steps, here's a video of what I'm seeing that might help shed some light on things maybe:



[Last edited by kieranmillar at 11-24-2020 08:41 PM]
11-24-2020 at 08:37 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
Xindaris
Level: Smitemaster
Avatar
Rank Points: 1017
Registered: 06-13-2015
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
While streaming TSS (latest beta update) today, I got basically the same kind of flickering in the one-tile platforms throughout Troshian Grounds. I can post a separate report in the DROD bugs board if desired.

____________________________
109th Skywatcher

Here are some links to Things!
Click here to view the secret text


[Last edited by Xindaris at 11-28-2020 11:04 PM]
11-28-2020 at 11:03 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
Xindaris wrote:
While streaming TSS (latest beta update) today, I got basically the same kind of flickering in the one-tile platforms throughout Troshian Grounds. I can post a separate report in the DROD bugs board if desired.
Yeah, I thought we'd have the same issue in both engines, as they're using the same new code for platform shading. You don't have to post a separate report; we'll fix the issue for both games once we isolate root cause.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
11-29-2020 at 05:38 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
Skell, can you reproduce what is being shown in the video here, either in RPG or TSS? I can't see it on my end.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
11-30-2020 at 02:04 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
RabidChild
Level: Smitemaster
Avatar
Rank Points: 688
Registered: 01-15-2006
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
I was able to reproduce this with kieranmillar's test hold in 1.2.8.345 on Windows. When playtesting in the editor, initially, some of the shadows are missing, though there doesn't seem to be any consistency about which tiles have shadows and which don't. If I wait about 30 seconds, they start to flicker and continue to flicker consistently until I close DROD RPG and reload it.

The same thing happens in TSS 5.1.1.344.
12-01-2020 at 01:37 PM
View Profile Send Private Message to User Show all user's posts High Scores Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
RabidChild wrote:
I was able to reproduce this with kieranmillar's test hold in 1.2.8.345 on Windows. When playtesting in the editor, initially, some of the shadows are missing, though there doesn't seem to be any consistency about which tiles have shadows and which don't. If I wait about 30 seconds, they start to flicker and continue to flicker consistently until I close DROD RPG and reload it.

The same thing happens in TSS 5.1.1.344.
Glad you're able to reproduce this! I appreciate you writing up these steps.

The glitchiness in the video above definitely looks bad and should be fixed.

Unfortunately, I tried this out on my end and I'm not seeing any shadow issues at all after waiting idle during an editor playtest session for a few minutes.

What graphical and system settings are you using? For instance:

* Full screen or windowed during play?
* Environmental and alpha settings on your player profile
* Monitor resolution
* OS
* any other specific graphics tweaks you've applied to DROD, e.g., in your INI file, etc.

Hopefully we can find a correlation for you and Kieran that can help me reproduce the issue on my end and then isolate root cause.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 12-01-2020 05:20 PM]
12-01-2020 at 05:19 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Schik
Level: Legendary Smitemaster
Avatar
Rank Points: 5311
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (+10)  
Mike, did you try it in a release build? I can reproduce this easily in release, but not in debug, which is super fun.

____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi
12-01-2020 at 05:46 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (+2)  
Schik wrote:
Mike, did you try it in a release build? I can reproduce this easily in release, but not in debug, which is super fun.
Thank you! Yes, that was it, apparently. I can see the issue in a Release build. I'm on the case.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
12-01-2020 at 05:58 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (0)  
Issue was a non-initialized member var in a copy constructor.

Fixed for RPG 1.2.8 and 5.1.1 in this PR.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
12-01-2020 at 10:49 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2273
Registered: 07-11-2014
IP: Logged
icon Re: Regression: Wall shadows on platform over pit flickering (+1)  
Can confirm fixed in 1.2.8.365
12-02-2020 at 05:45 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD RPG Boards : RPG Bugs : Regression: Wall shadows on platform over pit flickering
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.