Announcement: Be excellent to each other.


Caravel Forum : DROD Boards : Bugs : Variables in minimap's room preview (They are not used)
New Topic New Poll Post Reply
Poster Message
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged

File: BUG REPORT Variables in preview.hold (1.8 KB)
Downloaded 39 times.
License: Public Domain
icon Variables in minimap's room preview (+2)  
Example hold attached.

Suppose you have a room with the following script:

  Wait until var "ASD" = 1
  Display Filter Negative


If ASD is equal to one, the room will display with negative filter applied. If, however, you leave the room and click on it on the minimap the filter will not applied (remove "Wait until var..." and it will be). A quick look at the code suggests that the reason is when generating a preview, a temporary game state is created and used for the rendering, and while some global things are populated, the variables are not.

The remedy is, of course, to make it so that the variables are indeed copied over to the temporary game. Which I'll do.

____________________________
My website | Facebook | Twitter
09-28-2020 at 08:35 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3734
Registered: 12-28-2004
IP: Logged
icon Re: Variables in minimap's room preview (+2)  
And a pull request: https://github.com/CaravelGames/drod/pull/61

____________________________
My website | Facebook | Twitter
09-28-2020 at 09:02 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged
icon Re: Variables in minimap's room preview (+1)  
Can confirm in 5.1.1.alpha.2020-10-16 that the example hold works correctly.
10-17-2020 at 02:18 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD Boards : Bugs : Variables in minimap's room preview (They are not used)
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.