hyperme
Level: Smitemaster

Rank Points: 1062
Registered: 06-23-2006
IP: Logged

Currently, the Goblin and Wyrm weakness behaviors only apply for weapons, and not for Shields and Accessories.

To be true to Tower of the Sorcerer, and also to provide more flexibility in Level Set creation, it would be nice if Goblin Weakness and Wyrm Weakness also worked when on an accessory.

It would be also neat if it worked on shields. Alternately, Weakness Shields would half the ATK of weak enemies, or double the players DEF when fighting weak enemies.

____________________________
[Insert witty comment here]
Qzvlkx?

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Appreciate the mention here and the PR on Github. This change is approved for a future version.

The current behavior of not having these checks was probably an oversight originally and is likely, technically, a bug.

Request for community feedback: Should this be fixed for 1.2.8 or kept till the next major release (1.3)?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 09-23-2020 02:04 AM]

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

I don't think it matters which version it goes into. I do not know of any published user holds on the Holds board that have custom shields or accessories with these properties, because it never worked before so nobody included them, sobut fixing this won't impact leaderboard scores.

I can't vouch for everything in Architecture but I doubt they would be present on anything there either.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
I don't think it matters which version it goes into. I do not know of any published user holds on the Holds board that have custom shields or accessories with these properties, because it never worked before so nobody included them, sobut fixing this won't impact leaderboard scores.

I can't vouch for everything in Architecture but I doubt they would be present on anything there either.

Okay, great. I'm all for getting fixes in place sooner rather than later when there's the option.

I'll merge this change in for 1.2.8 then.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm in 1.2.8alpha.2020-09-24 that giving an accessory Goblin Weakness doubles your ATK against goblins, and Wyrm Weakness doubles attack against snakes.

It does not do anything when on shields, as expected.

Can also confirm a quick regression on putting it on custom swords still works and also the goblin-biter still works as expected.