kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

We have events that fire when you pick up equipment or keys (Received Equipment, Received Key) but not when picking up health potions or stat gems.

P.S. Does event Item Used only fire when you spend a key to open a door? Because it seems that way, and if so, it seems identical to Knocked Open Door (which is probably better named as Key Door Opened or something)

---

[Last edited by kieranmillar at 03-25-2016 07:43 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
We have events that fire when you pick up equipment or keys (Received Equipment, Received Key) but not when picking up health potions or stat gems.

I've added an event for each of these and exposed them to scripting.

PR

I note these had an internal event type that was overloaded with consuming a speed/invisibility potion. Currently, the event is only used to play the same "power-up" sound effect for each. I'm going to decouple this potion event from the atk/def/hp pickups and expose it as its own distinct script check as well.

I plan to add new sfx for the atk/def pickups. Maybe also swap out the "potion" sound when an invisibility/speed potion is activated for something else that sounds more like drinking a potion. Or we could do it the other way around: have one or more new sounds for the various types of HP pickups and keep the original for the invisibility/speed potions.

Opinions?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 11-07-2020 05:26 PM]

Chaco
Level: Smitemaster
Rank Points: 3626
Registered: 10-06-2005
IP: Logged

I'd be in favor of:

* New SFX for ATK and DEF gems (maybe separate ones for each?)
* New SFX for health potions (There's no analogous concept in DROD so having a new SFX would make some amount of sense, plus of all the pickups, health potions are usually the one that the player grabs several of rapidly.)
* Keep original SFX for speed/invisibility potions since that's the same SFX used when drinking them in DROD.

____________________________
Quick links to my stuff (in case you forgot where it was):

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

Thanks for the feedback. I was thinking the same thing!

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

Added more power-up goodies for 1.3.

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Regarding the new SFX, I think they are very quiet compared to other sounds. DROD has always had really loud splat and orb strike sounds, and when I set the volume level to a level where these sounds are manageable, I cannot hear the new pickup SFX.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Bump. While the original topic is addressed I still think the new SFX are way too quiet and could use being boosted to the same level as other sound effects like the sword swipe. Most of the typical DROD sound effects are actually quite loud.