Announcement: Be excellent to each other.


Caravel Forum : DROD RPG Boards : RPG Bugs : Portable orb use: script event fix
New Topic New Poll Post Reply
Poster Message
Nuntar
Level: Smitemaster
Avatar
Rank Points: 4596
Registered: 02-20-2007
IP: Logged
icon Portable orb use: script event fix (0)  
Blondbeard discovered this issue and asked me to write it up for him. "Wait for event <Player activates orb>" is triggered when the player uses the Portable Orb accessory. Semantically, one could argue that the Portable Orb is an orb, but practically from the architect's point of view this behaviour is almost always undesirable.

____________________________
50th Skywatcher

[Last edited by mrimer at 02-20-2016 02:42 PM]
01-20-2016 at 12:30 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5064
Registered: 02-04-2003
IP: Logged
icon Re: Portable orb bug? (0)  
Yes, this is by design. We could change this if it won't break anything.
Nuntar wrote:
from the architect's point of view this behaviour is almost always undesirable.
Why is this typically undesirable?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
01-20-2016 at 04:27 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
Nuntar
Level: Smitemaster
Avatar
Rank Points: 4596
Registered: 02-20-2007
IP: Logged
icon Re: Portable orb bug? (0)  
(Sorry, I kind of forgot to come back to this topic.) It's undesirable because "Wait for event Player triggers orb" is generally used to test for the striking of a particular orb in a room. ("Wait for door to open at" may not be a suitable substitute; you may wish to have an orb scripted to do something, and not connected to any doors.) With the current behaviour, the architect must remember to program a separate check and abort the script if the player has used the portable orb; worse, architects may not know about this exception and so unintended behaviour may slip into holds as a result.

Conversely, I can't imagine a case where one would need a check for "has the player either just struck an orb or used the Portable Orb?", but supposing one did, it would be easy enough to test for the two separately.

____________________________
50th Skywatcher
02-11-2016 at 02:11 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5064
Registered: 02-04-2003
IP: Logged
icon Re: Portable orb bug? (0)  
Okay, that makes sense. Any objections from other architects on making this change in a future build?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
02-11-2016 at 02:15 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 5064
Registered: 02-04-2003
IP: Logged
icon Re: Portable orb use: script event fix (0)  
Now activating a portable orb will no longer trigger the "Player activates orb" script event (rev 229).

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
02-20-2016 at 02:50 PM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged
icon Re: Portable orb use: script event fix (+1)  
Can confirm in Steam v1.2.5.230 that using the portable orb does not trigger "Player Activates Orb" while striking a regular orb does. :thumbsup
02-20-2016 at 06:57 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD RPG Boards : RPG Bugs : Portable orb use: script event fix
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.