bomber50
Level: Smitemaster
Rank Points: 873
Registered: 09-18-2006
IP: Logged

1. Create a hold.
2. Copy any room from it.
3. Delete this hold
4. Create a new hold.
5. Attempt to copy the room into the hold.

This causes the game to quit. Only appears to work for rooms, and not levels. If you do this with a level, nothing happens when you attempt to paste.

Expected behaviours: room copies, or nothing happens. Nothing happens probably a better idea, for consistency.

---

[Last edited by bomber50 at 06-02-2015 10:51 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5433
Registered: 02-04-2003
IP: Logged

Bump.

mrimer
Level: Legendary Smitemaster

Rank Points: 5433
Registered: 02-04-2003
IP: Logged

Wow, this issue seems to have been around forever. Easily fixed in rev 6315.

Edit: Skell, I've documented this fix here. If it needs to go somewhere else also for 5.1 documentation on the forum, please let me know.

Also, I'm not sure how you want to cherry pick changes I've been making on the dev branch into 5.1. There are multiple changes I've made -- not Steam related -- that I think should go into 5.1. Also, your 5.1 fixes should be merged into the dev branch. How do you want to handle this process?

---

[Last edited by mrimer at 12-11-2015 05:06 AM]

skell
Level: Legendary Smitemaster

Rank Points: 3864
Registered: 12-28-2004
IP: Logged

mrimer wrote:
Also, I'm not sure how you want to cherry pick changes I've been making on the dev branch into 5.1. There are multiple changes I've made -- not Steam related -- that I think should go into 5.1. Also, your 5.1 fixes should be merged into the dev branch. How do you want to handle this process?

Oh boy, I don't think that will be possible to merge it intelligently...

I guess the only real solution is to merge 5.1 into dev, stabilize dev and only then release the update which is probably going to push the release date forward in time again .

____________________________
My website

mrimer
Level: Legendary Smitemaster

Rank Points: 5433
Registered: 02-04-2003
IP: Logged

We could try cherry-picking individual commits into the 5.1 branch, but I realize we should have done a couple things differently (mostly me). I should have performed Steam dev work on a separate branch, or maybe just the SDL2 branch, so you could continue making 5.1 fixes on the dev branch without interruption. I didn't have the SDL2 branch building yet when I made my Steam changes, so I did these backwards. My apologies for the faux pas.

At this point, it is probably for the best to merge everything into dev and stabilize it. (Would you please review my changes at your convenience?)

---

[Last edited by mrimer at 12-11-2015 02:29 PM]

kieranmillar
Level: Smitemaster
Rank Points: 3699
Registered: 07-11-2014
IP: Logged

Cam confirm this works in 5.1.0.6345 and the game does not crash