TFMurphy
Level: Smitemaster
Rank Points: 3118
Registered: 06-11-2007
IP: Logged

Here's a fun little bug, based around Custom Equipment that tinker with stats and go to level entrances under certain conditions.

As a full example, let's say the player has a Custom Armor with the following script:

  Each defend "Defend"
  Go to "End"
Label "Defend"
  If ... 
        Wait until var _HP < 1
     Set var _HP = 1
     Go to level entrance "Hospital: Once West: Waking up"
  If End 
Label "End"

Now, right-clicking on an enemy that you cannot kill in one hit will start causing problems. You will get the Expected Damage of Death, even if you would easily survive the fight and not trigger the Level Entrance move. On top of this, various effects may occur immediately after this, including any movement causing the previous movement to replay, or the Go to Level Entrance command being run, or similar. Undoing from this can also cause problems, like completely removing the last enemy you killed in such a way that restarting the room doesn't cause it to reappear.

Whilst the "Go to Level Entrance" command is obviously the major trigger for this, it's not the only problem. If you remove the command, for example, and leave this piece of equipment as something that keeps your HP at a minimum of 1, then the Expected Damage for all fights where you take any damage at all is Death, even if you would come nowhere near the amount of HP needed to activate the condition. (Attacking a Roach when you have 40 ATK and 10000 HP, as an example, would still show an Expected Damage of Death.)

I realise this is a rather unorthodox use of custom equipment, but having it work as you might expect from the code could allow for some very interesting behaviour, and at the very least, the bugs resulting from this need to be closed up somehow.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Thanks for reporting this. The root of this problem appears to be that projecting damage from a duel starts the player with a theoretical HP of UINT(-1) (maximum unsigned 32-bit integer), in order to see how much damage the player might take. This causes the shield script query for player HP < 0 to inadvertently trigger on the first round of combat.

Starting the predicted combat at MAX_INT instead of UINT(-1) won't cause the "hospital" event to trigger. I couldn't see any other problems occurring after this fix was applied. I'll consider this fixed in rev 145.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

I can confirm that checking for HP values of less than 1 inside an equipment use label doesn't cause any problems, and triggers when you'd expect in 1.2.3.148

I tried a couple of things, including fighting monsters with the maximum possible attack value, and was never able to get the expected damage to mess up or otherwise cause issues.

EDIT: No wait, it looks like a roach egg that I don't have enough damage to hurt gives a predicted battle result of "Death", which is clearly untrue because it has 0 attack. In build 57 it showed "Cannot be hurt by your attack" instead.

---

[Last edited by kieranmillar at 01-24-2016 07:31 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
EDIT: No wait, it looks like a roach egg that I don't have enough damage to hurt gives a predicted battle result of "Death", which is clearly untrue because it has 0 attack. In build 57 it showed "Cannot be hurt by your attack" instead.

Good catch! This is a regression introduced in rev 145 (support for scripted checks for negative HP during combat projections). Fixed in rev 152.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

mrimer wrote:

kieranmillar wrote:
EDIT: No wait, it looks like a roach egg that I don't have enough damage to hurt gives a predicted battle result of "Death", which is clearly untrue because it has 0 attack. In build 57 it showed "Cannot be hurt by your attack" instead.

Good catch! This is a regression introduced in rev 145 (support for scripted checks for negative HP during combat projections). Fixed in rev 152.

Can confirm fixed in 1.2.3.152