kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

File: BUG REPORT Platform shadows.drh (856 bytes)
Downloaded 51 times.
License: Public Domain

See attached example hold.

When room darkness is zero so shadows are enabled, the shadows flicker in and out of existence sometimes.

This is best seen by playesting the rooms in the editor. Swapping between rooms sometimes also causes shadows to start flickering.

---

[Last edited by kieranmillar at 11-22-2020 03:12 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

This is in version 1.2.8.345, correct?

I'm not able to reproduce any flickering in my current build.

I've tried in the editor, in windowed and full screen, and when setting the repeat rate to slow, medium, and fast.

Can you provide more steps to reproduce?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

mrimer wrote:
This is in version 1.2.8.345, correct?

Yes.

In the absence of being able to figure out a consistent set of steps, here's a video of what I'm seeing that might help shed some light on things maybe:

---

[Last edited by kieranmillar at 11-24-2020 08:41 PM]

Xindaris
Level: Smitemaster

Rank Points: 1531
Registered: 06-13-2015
IP: Logged

While streaming TSS (latest beta update) today, I got basically the same kind of flickering in the one-tile platforms throughout Troshian Grounds. I can post a separate report in the DROD bugs board if desired.

____________________________
109th Skywatcher

Here are some links to Things!

---

[Last edited by Xindaris at 11-28-2020 11:04 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Xindaris wrote:
While streaming TSS (latest beta update) today, I got basically the same kind of flickering in the one-tile platforms throughout Troshian Grounds. I can post a separate report in the DROD bugs board if desired.

Yeah, I thought we'd have the same issue in both engines, as they're using the same new code for platform shading. You don't have to post a separate report; we'll fix the issue for both games once we isolate root cause.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Skell, can you reproduce what is being shown in the video here, either in RPG or TSS? I can't see it on my end.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

RabidChild
Level: Smitemaster
Rank Points: 720
Registered: 01-15-2006
IP: Logged

I was able to reproduce this with kieranmillar's test hold in 1.2.8.345 on Windows. When playtesting in the editor, initially, some of the shadows are missing, though there doesn't seem to be any consistency about which tiles have shadows and which don't. If I wait about 30 seconds, they start to flicker and continue to flicker consistently until I close DROD RPG and reload it.

The same thing happens in TSS 5.1.1.344.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

RabidChild wrote:
I was able to reproduce this with kieranmillar's test hold in 1.2.8.345 on Windows. When playtesting in the editor, initially, some of the shadows are missing, though there doesn't seem to be any consistency about which tiles have shadows and which don't. If I wait about 30 seconds, they start to flicker and continue to flicker consistently until I close DROD RPG and reload it.

The same thing happens in TSS 5.1.1.344.

Glad you're able to reproduce this! I appreciate you writing up these steps.

The glitchiness in the video above definitely looks bad and should be fixed.

Unfortunately, I tried this out on my end and I'm not seeing any shadow issues at all after waiting idle during an editor playtest session for a few minutes.

What graphical and system settings are you using? For instance:

* Full screen or windowed during play?
* Environmental and alpha settings on your player profile
* Monitor resolution
* OS
* any other specific graphics tweaks you've applied to DROD, e.g., in your INI file, etc.

Hopefully we can find a correlation for you and Kieran that can help me reproduce the issue on my end and then isolate root cause.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 12-01-2020 05:20 PM]

Schik
Level: Legendary Smitemaster

Rank Points: 5381
Registered: 02-04-2003
IP: Logged

Mike, did you try it in a release build? I can reproduce this easily in release, but not in debug, which is super fun.

____________________________
The greatness of a nation and its moral progress can be judged by the way it treats its animals.
--Mahatma Gandhi

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Schik wrote:
Mike, did you try it in a release build? I can reproduce this easily in release, but not in debug, which is super fun.

Thank you! Yes, that was it, apparently. I can see the issue in a Release build. I'm on the case.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Issue was a non-initialized member var in a copy constructor.

Fixed for RPG 1.2.8 and 5.1.1 in this PR.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 1.2.8.365