greenscience
Level: Master Delver
Rank Points: 141
Registered: 02-27-2015
IP: Logged

This regression was introduced between the 10/30 alpha and 11/10a alpha. After triggering a checkpoint with cutscene in the same script like the first checkpoint in RPG Mini, minimize and restore the game window then close checkpoint. This puts the game in a state where player cannot move. Pressing undo afterwards allows moving with keyboard but not mouse, then trying to fight monsters prevents movement again.

A minimal script to reproduce the issue is:

Wait for player to touch me
Cut scene 1
Score Checkpoint

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Wow this is an odd bug.

The issue seems to be that when you lose focus and restore while the score checkpoint window is up, something prevents the cutscene from progressing properly. Undoing leaves you inside the cutscene even if you undo to a time when the cutscene shouldn't have started yet, and movement stops responding when the game tries to open the score checkpoint window again.

Swapping focus and back again once the score checkpoint window is closed restores normal functionality.

EDIT: This is happening with Yes/No question dialogs inside cutscenes too.

---

[Last edited by kieranmillar at 11-16-2020 09:21 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
Wow this is an odd bug.

The issue seems to be that when you lose focus and restore while the score checkpoint window is up, something prevents the cutscene from progressing properly.
...
Swapping focus and back again once the score checkpoint window is closed restores normal functionality.

EDIT: This is happening with Yes/No question dialogs inside cutscenes too.

Yep, this is all correct. Good sleuthing!

I think I've isolated the root cause: it's a regression in this
PR. The new logic in CGameScreen::OnWindowEvent_GetFocus() sets dwTimeMinimized, which causes progression of the cut scene to hang.

The logic in CGameScreen::OnWindowEvent_GetFocus() and CGameScreen::OnWindowEvent_LoseFocus() appears to be backwards from the logic in CGameScreen::OnWindowEvent() just above them. (For instance, why pause sounds when we're getting focus back? I'm not sure how this worked before, and I think this same issue happens in 5.1.1 with a question dialog during a cutscene.)

Skell, can you confirm the logic in these events is backwards? I'm putting up a PR to flip them. That resolves this issue, but please let me know if I'm missing something.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 11-17-2020 11:02 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

PR

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

Can confirm fixed in 1.2.8.339