coppro
Level: Smitemaster
Rank Points: 1309
Registered: 11-24-2005
IP: Logged

Platform: Linux

How to reproduce: Do not connect to the Internet. Attempt to request a new CaravelNet key.

Observed behaviour: DROD crashes.

Expected behaviour: DROD does not crash.

Tuttle
Level: Smitemaster

Rank Points: 1547
Registered: 02-22-2003
IP: Logged

Reproducible on Windows. Not a crash in the "drod.exe has stopped working" sense, but an immediate quit to Desktop.

Elfstone
Level: Smitemaster

Rank Points: 1285
Registered: 03-01-2006
IP: Logged

This was within my capabilities to test.
It also happens on my computer : Intel Mac G5, OS 10.6.8

____________________________
Winner of: Novice Architect Excellence 2006.
FAPCA - Technical Design Excellence in Layout and Aesthetics

mrimer
Level: Legendary Smitemaster

Rank Points: 5106
Registered: 02-04-2003
IP: Logged

I think I found it. We were missing a check here, and in a few other places, for actually receiving the result buffer from the server before attempting to read it.

My changes might possibly fix the initial crash players were seeing happen once on start-up.

Devs, would you please review my code changes here (rev 5938)?

Fixed for 5.0.1.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.