ErikH2000
Level: Legendary Smitemaster

Rank Points: 2794
Registered: 02-04-2003
IP: Logged

I have a project where it is necessary to have many, many stub functions with unused parameters. The project must also compile under both GCC and MSVC. A function like this:

void DogFunc(char HappyBone)
{ }

...will generate an unused variable warning in GCC. I can get around this by enclosing the variable name in comments, like so:

void DogFunc(char /* HappyBone */ )
{ }

...but then VC will not compile it, giving me "error C2055: expected formal parameter list, not a type list".

I can do some dummy assigns on the parameters to get both compilers to shut up, but maybe there is a more elegant solution?

-Erik

____________________________
The Godkiller - Chapter 1 available now on Steam. It's a DROD-like puzzle adventure game.
dev journals | twitch stream | youtube archive (NSFW)

ErikH2000
Level: Legendary Smitemaster

Rank Points: 2794
Registered: 02-04-2003
IP: Logged

I talked to some other people and the solution I have is to just make dummy assigns, but put it in an UNUSED() macro to make the code look a little cleaner.

#define UNUSED(x) x = x

void DogFunc(char HappyBone)
{
  UNUSED(HappyBone);
}

What a finicky fellow I am.

-Erik

____________________________
The Godkiller - Chapter 1 available now on Steam. It's a DROD-like puzzle adventure game.
dev journals | twitch stream | youtube archive (NSFW)

bradwall
Level: Smiter

Rank Points: 423
Registered: 02-12-2003
IP: Logged

In VC++, if you set the warning level to 4 you will also get the warning:

warning C4100: 'HappyBone' : unreferenced formal parameter

You can disable this specific warning by adding the following line at the top of your code:

#pragma warning(disable: 4100)

I'm not sure how to do this with GCC

trick
Level: Legendary Smitemaster
Rank Points: 2580
Registered: 04-12-2003
IP: Logged

There's a gcc option you can use. If you pass the -Wno-unused-parameter option to gcc, it won't complain about unused parameters. You could also fix it in the source code itself by using variable attributes (should be available in any version of gcc you'd want to use, I think):

void DogFunc(char HappyBone __attribute__((__unused__)))
{
  ...
}

You'll need a macro to make that portable though:

#ifdef __GNUC__
#define UNUSED __attribute__((__unused__))
#else
#define UNUSED
#endif

void DogFunc(char HappyBone UNUSED)
{
  ..
}

I have no idea why I didn't use this in DROD.

- Gerry