Announcement: Be excellent to each other.


Caravel Forum : DROD RPG Boards : RPG Bugs : Regression: Dark rooms leave sword artifacts outside room border
New Topic New Poll Post Reply
Poster Message
kieranmillar
Level: Smitemaster
Rank Points: 2273
Registered: 07-11-2014
IP: Logged
icon Regression: Dark rooms leave sword artifacts outside room border (+1)  
- Make a room dark enough so that the player gets their own light source.
- Give the player a sword.
- Stand on a room border with the sword outside of the room boundary, then step back into the room.

A visual imprint of the sword is left behind outside of the room border.
11-14-2020 at 03:07 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
skell
Level: Legendary Smitemaster
Avatar
Rank Points: 3500
Registered: 12-28-2004
IP: Logged
icon Re: Regression: Dark rooms leave sword artifacts outside room border (+1)  
I think it's also in regular DROD, cause yesterday when checking demos I saw a sword artifact beyond southern room edge.

____________________________
My website | Facebook | Twitter
11-15-2020 at 07:49 AM
View Profile Send Private Message to User Send Email to User Visit Homepage Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Dark rooms leave sword artifacts outside room border (0)  
skell wrote:
I think it's also in regular DROD, cause yesterday when checking demos I saw a sword artifact beyond southern room edge.
Thanks. I've reproduced the issue and I'm looking into it.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.
11-17-2020 at 01:13 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Dark rooms leave sword artifacts outside room border (0)  
Update: I think this particular issue has to do with a clipping rectangle being defined in CRoomWidget::DrawTileLight(), and then it being re-applied in AddLight(). When at the room boundary, it only needs to be applied once, not twice.

There's also an issue with lighting not being drawn at all as the weapon is moving out beyond the edge of the room. Lighting should be applied to the moving weapon sprite both while exiting and entering the room area.

Edit: Oh. And there's the big TODO in AddLight that says clipping isn't implemented yet. That would do it.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 11-17-2020 03:06 AM]
11-17-2020 at 02:26 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
mrimer
Level: Legendary Smitemaster
Avatar
Rank Points: 4729
Registered: 02-04-2003
IP: Logged
icon Re: Regression: Dark rooms leave sword artifacts outside room border (+2)  
This turned out to be another rabbit hole, requiring cleanup of multiple levels of subtle calculation bugs in clipping and applying lighting at the room boundary.

There were more issues than just this once, it turns out.

PR

Weapon rendering at the room edge now looks perfect to me. I'll provide an analogous PR for 5.1.1 after this one is approved and merged.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

[Last edited by mrimer at 11-17-2020 09:08 AM]
11-17-2020 at 09:07 AM
View Profile Send Private Message to User Send Email to User Show all user's posts High Scores This architect's holds Quote Reply
kieranmillar
Level: Smitemaster
Rank Points: 2273
Registered: 07-11-2014
IP: Logged
icon Re: Regression: Dark rooms leave sword artifacts outside room border (+1)  
Can confirm fixed in 1.2.8.339.
11-18-2020 at 06:50 PM
View Profile Send Private Message to User Show all user's posts High Scores This architect's holds Quote Reply
New Topic New Poll Post Reply
Caravel Forum : DROD RPG Boards : RPG Bugs : Regression: Dark rooms leave sword artifacts outside room border
Surf To:


Forum Rules:
Can I post a new topic? No
Can I reply? No
Can I read? Yes
HTML Enabled? No
UBBC Enabled? Yes
Words Filter Enable? No

Contact Us | CaravelGames.com

Powered by: tForum tForumHacks Edition b0.98.8
Originally created by Toan Huynh (Copyright © 2000)
Enhanced by the tForumHacks team and the Caravel team.