hyperme
Level: Smitemaster

Rank Points: 1064
Registered: 06-23-2006
IP: Logged

As reported by NiroZ in the patch thread:

NiroZ wrote:
There seems to be a new bug created however which is getting in the way of testing. When you're in the hold editor if you click the monster tab, the ice tile, the platform tile, any of the 3 bridge tiles, the spike tile, the heat trap, the image insertion tiles, the light, grey and dark tiles, the checkmark tile, the horns, the beacons and the fluff cloud you get a CTD with no error message I could find.

I've checked and this is on version 5.1.1.alpha.2020-09-23 and this does not happen on 5.1.0.6512.

I've done some quick investigating and found two things:

This only happens in Release builds, not Debug builds
It also happens in DROD RPG builds

____________________________
[Insert witty comment here]
Qzvlkx?

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

Thank you for the repro steps.

I'm looking into this.

Appears that VS2019 supports debugging a Release build somehow in the IDE. That's nice.

I'm getting the crash pinpointed to here:

CTabbedMenuWidget::SelectTab()
...
CEventHandlerWidget *pEventHandler = GetEventHandlerWidget();

is returning a bad pointer address.



Edit: The exception is:

Exception thrown at 0x83018B66 in drod.exe: 0xC0000005: Access violation executing location 0x83018B66.

Thrown from the lower half of CEditRoomScreen::SetSelectedObject(). Which doesn't make any sense. Still trying to isolate the issue.


____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 09-24-2020 04:51 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

Well...I found a fix. It also makes no sense, which tells me there's something I'm still not understanding (PR link).

The situation conjures up phantoms of compiler bugs in my mind, but as long as the issue is gone, I guess I'm not going to complain.


____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

For completeness, this is fixed in 5.1.1.alpha.2020-10-18