Nuntar
Level: Smitemaster

Rank Points: 4596
Registered: 02-20-2007
IP: Logged

As Someone Else pointed out in beta, this is causing problems with a couple of scorepoints in my new hold Castle Repton.

____________________________
50th Skywatcher

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

Ah...to make sure I understand, you're saying that you would expect that a player in a monster role would not trigger the "Wait for/while entity Monster" check, correct?

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

Nuntar
Level: Smitemaster

Rank Points: 4596
Registered: 02-20-2007
IP: Logged

Sure. The player and monsters have very different gameplay functions, so it makes sense that can you test for either one individually. It's especially important in RPG because "Wait while entity Monster" is commonly used to trigger scorepoints, and the current behaviour can allow the player to delay or entirely bypass a trigger. In TSS you can usually get round this with "Wait while entity type [particular type of monster]", but we don't have that in RPG.

____________________________
50th Skywatcher

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

That makes sense. This should be easy to fix. I'm planning to make this change.

If anyone thinks this is a bad idea, please speak up.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

Fixed in rev 86.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

I can confirm that Steam beta 1.2.3.89 is not triggering Wait while entity Monster on a monster player role .

Out of interest I just checked and regular DROD 5.1.0.1007 has this bug where player roles will trigger Wait while entity monster. Worth fixing in regular DROd too? (I have no idea if it would mess up any existing demos or scripting though. Probably.)

---

[Last edited by kieranmillar at 01-06-2016 08:55 PM]

mrimer
Level: Legendary Smitemaster

Rank Points: 5064
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
Out of interest I just checked and regular DROD 5.1.0.1007 has this bug where player roles will trigger Wait while entity monster. Worth fixing in regular DROd too? (I have no idea if it would mess up any existing demos or scripting though. Probably.)

That was originally by design also. I'm fine removing the player-monster check if it won't mess up scripts/demos in 5.1.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.