hyperme
Level: Smitemaster

Rank Points: 1064
Registered: 06-23-2006
IP: Logged

If you edit a hold made by another and create your own copy, any Speech commands in default scripts break. I only found this out since I took over HA2, which has a few default scripts will Speech.

I can't really supply a example hold, but this should be easy enough to reproduce.

____________________________
[Insert witty comment here]
Qzvlkx?

Dischorran
Level: Smitemaster

Rank Points: 3407
Registered: 09-10-2005
IP: Logged

But are psychotic U.S. Supreme Court nominees involved?

____________________________

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

I can't reproduce it in Build 57 so I assume it has been somehow fixed in the meantime. I have downloaded latest version of HA2, copied it and checked the Elixir and Hungry Man in both - it worked the same.

____________________________
My website | Facebook | Twitter

TFMurphy
Level: Smitemaster
Rank Points: 3118
Registered: 06-11-2007
IP: Logged

No, this bug is still here, and it's also in [DROD 4.0] too now that that has Default Scripts. The important step is that after copying, you *delete* either the copy or the original. Default Character copies do not properly make Speech copies, so they simply have references to the original speech. Deleting either hold/level set causes the Speech to be deleted, which affects whichever hold was not deleted.

---

[Last edited by mrimer at 05-22-2012 06:37 PM]

skell
Level: Legendary Smitemaster

Rank Points: 3734
Registered: 12-28-2004
IP: Logged

TFMurphy wrote:
No, this bug is still here, and it's also in TCB too now that that has Default Scripts. The important step is that after copying, you *delete* either the copy or the original. Default Character copies do not properly make Speech copies, so they simply have references to the original speech. Deleting either hold/level set causes the Speech to be deleted, which affects whichever hold was not deleted.

Ah, I understand now. So the point is the speech should be also copied, right?

____________________________
My website | Facebook | Twitter

mrimer
Level: Legendary Smitemaster

Rank Points: 5058
Registered: 02-04-2003
IP: Logged

skell wrote:

TFMurphy wrote:
No, this bug is still here, and it's also in TCB too now that that has Default Scripts. The important step is that after copying, you *delete* either the copy or the original. Default Character copies do not properly make Speech copies, so they simply have references to the original speech. Deleting either hold/level set causes the Speech to be deleted, which affects whichever hold was not deleted.

Ah, I understand now. So the point is the speech should be also copied, right?

Yes, there should be a duplicate CDbData record created for each speech audio file in the hold default scripts. I'm not sure offhand why the copy is not happening, but it's likely discernible with a bit of determination. And a gob of resoluteness.

Edit: link to Robobob's 4.0 Porthole hold demo thread, from which we were somehow able to get the bug to surface.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 05-22-2012 06:45 PM]