Briareos
Level: Smitemaster

Rank Points: 3516
Registered: 08-07-2005
IP: Logged

File: shadow_fail.png (44.7 KB)
Downloaded 385 times.
License: Public Domain

As you can see in this image of Rule 7, 2N:


objects in the shadow are brighter than those not in it (especially the aumtlich beam and Tendry's sword).

Unless light works totally different on the Eighth (and that wouldn't be flawlessly consistent with earlier DRODs) I'd call that a bug...

Another shadow bug I've not depicted here would be shadows cast on platforms staying put for one turn after you moved the platform away from under it.

____________________________
"I'm not anti-anything, I'm anti-everything, it fits better." - Sole
R.I.P. Robert Feldhoff (1962-2009)

---

[Last edited by Briareos at 09-20-2008 05:13 PM]

The Architest
Level: Master Delver

Rank Points: 254
Registered: 05-25-2008
IP: Logged

Pretty bad graphic "bug"

It might be so that Aumtlich shut he's second eye!
(Aumtlich are such a lazy bums!)

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

Briareos wrote:
objects in the shadow are brighter than those not in it (especially the aumtlich beam and Tendry's sword).

This is a bug, and I think it exists in 3.x also (though less noticeable, of course), but would seem to require a heavy rewrite to the room graphics engine to fix. So, I'm going to mark it a known issue and leave it as-is for now. When the code is released, if some enterprising soul wants to try to invest the time to fix this, they'll be welcome to it.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

---

[Last edited by mrimer at 10-25-2008 05:42 AM]

Briareos
Level: Smitemaster

Rank Points: 3516
Registered: 08-07-2005
IP: Logged

mrimer wrote:
When the code is released, if some enterprising soul wants to try to invest the time to fix this, they'll be welcome to it.

Help! Help! I'm being tempted!

np: The Gasman - RXJ3 (Superlife)

____________________________
"I'm not anti-anything, I'm anti-everything, it fits better." - Sole
R.I.P. Robert Feldhoff (1962-2009)

NiroZ
Level: Smitemaster
Rank Points: 1302
Registered: 02-12-2006
IP: Logged

Now is the time you mention your looking for an extra coder who takes some initiative mrimer

halyavin
Level: Delver
Rank Points: 52
Registered: 02-20-2006
IP: Logged

This is just HDR at work .

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

While browsing these really old still-marked-as-outstanding bugs I saw that the original issue in this one has been fixed, and swords and other sprites that are in a wall shadow are now darkened correctly.

EXCEPT in testing this I have discovered another related bug, present in both 1.2.3.70 and Steam-beta versions. When you are stepping between tiles, the shadow is not applied during the "tweening" when Tendry walks between tiles. To reproduce, walk along the wall in the shadow with your sword in front of you, the sword will be rendered in full brightness in the frames between steps.

mrimer
Level: Legendary Smitemaster

Rank Points: 5056
Registered: 02-04-2003
IP: Logged

kieranmillar wrote:
I have discovered another related bug, present in both 1.2.3.70 and Steam-beta versions. When you are stepping between tiles, the shadow is not applied during the "tweening" when Tendry walks between tiles. To reproduce, walk along the wall in the shadow with your sword in front of you, the sword will be rendered in full brightness in the frames between steps.

Yeah, that was never implemented in the RPG engine. I've migrated support for this from the 5.x engine (rev 88).

I've also migrated support for light and shadow from point light sources being rendered correctly on moving sprites.

____________________________
Gandalf? Yes... That's what they used to call me.
Gandalf the Grey. That was my name.
I am Gandalf the White.
And I come back to you now at the turn of the tide.

kieranmillar
Level: Smitemaster
Rank Points: 2670
Registered: 07-11-2014
IP: Logged

mrimer wrote: Yeah, that was never implemented in the RPG engine. I've migrated support for this from the 5.x engine (rev 88).

This bug appears fixed in Steam beta 1.2.3.89

mrimer wrote: I've also migrated support for light and shadow from point light sources being rendered correctly on moving sprites.

To be honest I'm not sure what I'm looking for here, but when moving around in a room with a number of point lights and pushing mirrors I didn't notice any problems.