TFMurphy
Level: Smitemaster
Rank Points: 3118
Registered: 06-11-2007
IP: Logged
File: DROD Briar.patch (880 bytes) Downloaded 42 times. License: Public Domain
|
Re: Bug involving briars (possibly requiring gel,speed potions AND conquer tokens) (+4)
Okay, put together a patch for the first part of this issue. Well, I see it as an issue, anyways: it's not intuitive and very difficult to predict it'll happen - connecting briar shouldn't prevent a briar from taking its maturing turn.
Explanation of patch: Originally, when a briar is considered 'stuck', it's also considered 'done' with its turn. However, briar that belongs to another root is also considered an obstacle to briar growth until the two groups are joined. Group joining only happens after briar growth is considered, and if the briar was considered stuck before, it's now unstuck. However, it's still 'done' with its turn, which it shouldn't be since it now has a whole set of other briar tiles for it to check.
As such, I have removed the automatic "if stuck, briar is done with turn". Now, it waits until all merges have been done, and then if the briar is still stuck after that, only *then* is it done. Otherwise, it can go back and check if there's any edge tiles that need looking at, and if needs be, expand *again*.
Note: This *will* break some rooms. I've already found one of mine that's affected, simply because I had two roots growing together, and at *one* point, the first briar growth 'obstructs' the second. Threw the timing of the room right out, so if we go with this patch, I'll have to retime it. I don't mind doing that for my own rooms, of course, but I can't say what other rooms it will break.
Basically, any briar room that requires perfect timing and has multiple roots may become broken by this patch. Of course, it won't be the first time a change to briars has broken rooms, but fair warning in advance. Also, again, this is only if this particular quirk of briars gets fixed - if it doesn't, then you don't have to fear any change. But I still think it's a bug.
Finally, this does not do anything about the perceived problem with undo. I don't know what's causing that. I do know that Jacob's example hold no longer bugs, primarily because Beethro now dies when he should (I can't clear the gel in time, so the death is always like it was supposed to be). But whatever the root issue of that was, I don't know, and it might be worthwhile tracking it down. But I think it's possibly a bit beyond my scope.
Hope that helps.
[Last edited by TFMurphy at 08-03-2007 11:23 PM]
|